* [PATCH] bus: mhi: core: Improve debug messages for power on
@ 2021-04-27 1:00 Bhaumik Bhatt
2021-05-01 0:30 ` Hemant Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Bhaumik Bhatt @ 2021-04-27 1:00 UTC (permalink / raw)
To: manivannan.sadhasivam
Cc: linux-arm-msm, hemantk, jhugo, linux-kernel, loic.poulain, Bhaumik Bhatt
Improve error message to be more descriptive if a failure occurs
with an invalid power on execution environment. Also add a debug
message to print the execution environment and MHI state before
a power on is attempted to get a better view of device states.
Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
---
drivers/bus/mhi/core/pm.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c
index adf426c..f4a8b9a 100644
--- a/drivers/bus/mhi/core/pm.c
+++ b/drivers/bus/mhi/core/pm.c
@@ -1076,12 +1076,16 @@ int mhi_async_power_up(struct mhi_controller *mhi_cntrl)
/* Confirm that the device is in valid exec env */
if (!MHI_IN_PBL(current_ee) && current_ee != MHI_EE_AMSS) {
- dev_err(dev, "Not a valid EE for power on\n");
+ dev_err(dev, "%s is not a valid EE for power on\n",
+ TO_MHI_EXEC_STR(current_ee));
ret = -EIO;
goto error_async_power_up;
}
state = mhi_get_mhi_state(mhi_cntrl);
+ dev_dbg(dev, "Attempting power on with EE: %s, state: %s\n",
+ TO_MHI_EXEC_STR(current_ee), TO_MHI_STATE_STR(state));
+
if (state == MHI_STATE_SYS_ERR) {
mhi_set_mhi_state(mhi_cntrl, MHI_STATE_RESET);
ret = wait_event_timeout(mhi_cntrl->state_event,
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bus: mhi: core: Improve debug messages for power on
2021-04-27 1:00 [PATCH] bus: mhi: core: Improve debug messages for power on Bhaumik Bhatt
@ 2021-05-01 0:30 ` Hemant Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Hemant Kumar @ 2021-05-01 0:30 UTC (permalink / raw)
To: Bhaumik Bhatt, manivannan.sadhasivam
Cc: linux-arm-msm, jhugo, linux-kernel, loic.poulain
Hi Bhaumik,
On 4/26/21 6:00 PM, Bhaumik Bhatt wrote:
> Improve error message to be more descriptive if a failure occurs
> with an invalid power on execution environment. Also add a debug
> message to print the execution environment and MHI state before
> a power on is attempted to get a better view of device states.
Can we add a scenario where this dbg log can help ? That gives a good
justification for addition of new log.
>
> Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
> ---
> drivers/bus/mhi/core/pm.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c
> index adf426c..f4a8b9a 100644
> --- a/drivers/bus/mhi/core/pm.c
> +++ b/drivers/bus/mhi/core/pm.c
> @@ -1076,12 +1076,16 @@ int mhi_async_power_up(struct mhi_controller *mhi_cntrl)
>
> /* Confirm that the device is in valid exec env */
> if (!MHI_IN_PBL(current_ee) && current_ee != MHI_EE_AMSS) {
> - dev_err(dev, "Not a valid EE for power on\n");
> + dev_err(dev, "%s is not a valid EE for power on\n",
> + TO_MHI_EXEC_STR(current_ee));
> ret = -EIO;
> goto error_async_power_up;
> }
>
> state = mhi_get_mhi_state(mhi_cntrl);
> + dev_dbg(dev, "Attempting power on with EE: %s, state: %s\n",
> + TO_MHI_EXEC_STR(current_ee), TO_MHI_STATE_STR(state));
> +
> if (state == MHI_STATE_SYS_ERR) {
> mhi_set_mhi_state(mhi_cntrl, MHI_STATE_RESET);
> ret = wait_event_timeout(mhi_cntrl->state_event,
>
Thanks,
Hemant
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-01 0:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-27 1:00 [PATCH] bus: mhi: core: Improve debug messages for power on Bhaumik Bhatt
2021-05-01 0:30 ` Hemant Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).