From: Yang Li <yang.lee@linux.alibaba.com>
To: mporter@kernel.crashing.org
Cc: alex.bou9@gmail.com, linux-kernel@vger.kernel.org,
Yang Li <yang.lee@linux.alibaba.com>
Subject: [PATCH] drivers/rapidio/rio-scan.c: drop unneeded assignment in rio_enum_peer()
Date: Tue, 27 Apr 2021 19:23:15 +0800 [thread overview]
Message-ID: <1619522595-105320-1-git-send-email-yang.lee@linux.alibaba.com> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=n, Size: 1411 bytes --]
Making '<' operation with port->host_deviceid directly after
calling the function rio_get_host_deviceid_lock(() is more efficient,
so assignment to ‘tmp’ is redundant.
Eliminate the following clang_analyzer warning:
drivers/rapidio/rio-scan.c:561:10: warning: Although the value stored to
'tmp' is used in the enclosing expression, the value is never actually
read from 'tmp'
No functional change.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/rapidio/rio-scan.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/rapidio/rio-scan.c b/drivers/rapidio/rio-scan.c
index 19b0c33..2bc4d1e 100644
--- a/drivers/rapidio/rio-scan.c
+++ b/drivers/rapidio/rio-scan.c
@@ -524,7 +524,6 @@ static int rio_enum_peer(struct rio_net *net, struct rio_mport *port,
{
struct rio_dev *rdev;
u32 regval;
- int tmp;
if (rio_mport_chk_dev_access(port,
RIO_ANY_DESTID(port->sys_size), hopcount)) {
@@ -558,7 +557,7 @@ static int rio_enum_peer(struct rio_net *net, struct rio_mport *port,
rio_mport_write_config_32(port, RIO_ANY_DESTID(port->sys_size),
hopcount,
RIO_HOST_DID_LOCK_CSR, port->host_deviceid);
- while ((tmp = rio_get_host_deviceid_lock(port, hopcount))
+ while (rio_get_host_deviceid_lock(port, hopcount)
< port->host_deviceid) {
/* Delay a bit */
mdelay(1);
--
1.8.3.1
reply other threads:[~2021-04-27 11:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1619522595-105320-1-git-send-email-yang.lee@linux.alibaba.com \
--to=yang.lee@linux.alibaba.com \
--cc=alex.bou9@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mporter@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).