From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46EC0C433B4 for ; Thu, 29 Apr 2021 21:29:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B52D61441 for ; Thu, 29 Apr 2021 21:29:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236986AbhD2Vam (ORCPT ); Thu, 29 Apr 2021 17:30:42 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:44119 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233284AbhD2Vak (ORCPT ); Thu, 29 Apr 2021 17:30:40 -0400 X-Originating-IP: 90.65.108.55 Received: from localhost (lfbn-lyo-1-1676-55.w90-65.abo.wanadoo.fr [90.65.108.55]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 06E391BF204; Thu, 29 Apr 2021 21:29:51 +0000 (UTC) From: Alexandre Belloni To: Dario Binacchi , linux-kernel@vger.kernel.org Cc: Alexandre Belloni , Alessandro Zummo , linux-rtc@vger.kernel.org Subject: Re: [PATCH] rtc: omap: use rtc_write to access OMAP_RTC_OSC_REG Date: Thu, 29 Apr 2021 23:29:49 +0200 Message-Id: <161973168395.2582973.9374098143035295509.b4-ty@bootlin.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210425145924.23353-1-dariobin@libero.it> References: <20210425145924.23353-1-dariobin@libero.it> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 25 Apr 2021 16:59:23 +0200, Dario Binacchi wrote: > The RTC_OSC_REG register is 32-bit, but the useful information is found > in the 7 least significant bits (bits 7-31 are reserved). And in fact, > as you can see from the code, all read accesses are 8-bit, as well as > some writes. Let's make sure all writes are 8-bit. Moreover, in contexts > where consecutive reads / writes after the busy check must take place > within 15 us, it is better not to waste time on useless accesses. I really doubt writeb versus writel actually make a difference as the bus will probably still do a 32bit access. Applied, thanks! [1/1] rtc: omap: use rtc_write to access OMAP_RTC_OSC_REG commit: 50f2cc7f758cdbc7c8f928edc25b1c7bc09ef3e2 Best regards, -- Alexandre Belloni