* [PATCH] net: dsa: qca8k: fix noderef.cocci warnings
[not found] <202202100634.l8CtrpzE-lkp@intel.com>
@ 2022-02-09 22:13 ` kernel test robot
2022-02-10 3:30 ` Florian Fainelli
0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2022-02-09 22:13 UTC (permalink / raw)
To: Ansuel Smith
Cc: kbuild-all, Linux Memory Management List, Andrew Lunn,
Vivien Didelot, Florian Fainelli, Vladimir Oltean,
Jakub Kicinski, netdev, linux-kernel
From: kernel test robot <lkp@intel.com>
drivers/net/dsa/qca8k.c:422:37-43: ERROR: application of sizeof to pointer
sizeof when applied to a pointer typed expression gives the size of
the pointer
Generated by: scripts/coccinelle/misc/noderef.cocci
Fixes: 90386223f44e ("net: dsa: qca8k: add support for larger read/write size with mgmt Ethernet")
CC: Ansuel Smith <ansuelsmth@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 10207e3a840b47b5eae573486a88fb6e29884f77
commit: 90386223f44e2a751d7e9e9ac8f78ea33358a891 [2955/4656] net: dsa: qca8k: add support for larger read/write size with mgmt Ethernet
:::::: branch date: 16 hours ago
:::::: commit date: 7 days ago
qca8k.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/dsa/qca8k.c
+++ b/drivers/net/dsa/qca8k.c
@@ -419,7 +419,7 @@ qca8k_regmap_read(void *ctx, uint32_t re
u16 r1, r2, page;
int ret;
- if (!qca8k_read_eth(priv, reg, val, sizeof(val)))
+ if (!qca8k_read_eth(priv, reg, val, sizeof(*val)))
return 0;
qca8k_split_addr(reg, &r1, &r2, &page);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: dsa: qca8k: fix noderef.cocci warnings
2022-02-09 22:13 ` [PATCH] net: dsa: qca8k: fix noderef.cocci warnings kernel test robot
@ 2022-02-10 3:30 ` Florian Fainelli
2022-02-10 18:59 ` Jakub Kicinski
0 siblings, 1 reply; 4+ messages in thread
From: Florian Fainelli @ 2022-02-10 3:30 UTC (permalink / raw)
To: kernel test robot, Ansuel Smith
Cc: kbuild-all, Linux Memory Management List, Andrew Lunn,
Vivien Didelot, Vladimir Oltean, Jakub Kicinski, netdev,
linux-kernel
On 2/9/2022 2:13 PM, kernel test robot wrote:
> From: kernel test robot <lkp@intel.com>
>
> drivers/net/dsa/qca8k.c:422:37-43: ERROR: application of sizeof to pointer
>
> sizeof when applied to a pointer typed expression gives the size of
> the pointer
>
> Generated by: scripts/coccinelle/misc/noderef.cocci
>
> Fixes: 90386223f44e ("net: dsa: qca8k: add support for larger read/write size with mgmt Ethernet")
> CC: Ansuel Smith <ansuelsmth@gmail.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: dsa: qca8k: fix noderef.cocci warnings
2022-02-10 3:30 ` Florian Fainelli
@ 2022-02-10 18:59 ` Jakub Kicinski
2022-02-11 6:36 ` [kbuild-all] " Chen, Rong A
0 siblings, 1 reply; 4+ messages in thread
From: Jakub Kicinski @ 2022-02-10 18:59 UTC (permalink / raw)
To: Florian Fainelli, kernel test robot, kbuild-all
Cc: Ansuel Smith, Linux Memory Management List, Andrew Lunn,
Vivien Didelot, Vladimir Oltean, netdev, linux-kernel
On Wed, 9 Feb 2022 19:30:48 -0800 Florian Fainelli wrote:
> On 2/9/2022 2:13 PM, kernel test robot wrote:
> > From: kernel test robot <lkp@intel.com>
> >
> > drivers/net/dsa/qca8k.c:422:37-43: ERROR: application of sizeof to pointer
> >
> > sizeof when applied to a pointer typed expression gives the size of
> > the pointer
> >
> > Generated by: scripts/coccinelle/misc/noderef.cocci
> >
> > Fixes: 90386223f44e ("net: dsa: qca8k: add support for larger read/write size with mgmt Ethernet")
> > CC: Ansuel Smith <ansuelsmth@gmail.com>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: kernel test robot <lkp@intel.com>
>
> > qca8k.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
kbuild folks, would it be easy to switch to including full path here?
It seems like our CI expects that and ignores this patch.
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [kbuild-all] Re: [PATCH] net: dsa: qca8k: fix noderef.cocci warnings
2022-02-10 18:59 ` Jakub Kicinski
@ 2022-02-11 6:36 ` Chen, Rong A
0 siblings, 0 replies; 4+ messages in thread
From: Chen, Rong A @ 2022-02-11 6:36 UTC (permalink / raw)
To: Jakub Kicinski, Florian Fainelli, kernel test robot, kbuild-all
Cc: Ansuel Smith, Linux Memory Management List, Andrew Lunn,
Vivien Didelot, Vladimir Oltean, netdev, linux-kernel
On 2/11/2022 2:59 AM, Jakub Kicinski wrote:
> On Wed, 9 Feb 2022 19:30:48 -0800 Florian Fainelli wrote:
>> On 2/9/2022 2:13 PM, kernel test robot wrote:
>>> From: kernel test robot <lkp@intel.com>
>>>
>>> drivers/net/dsa/qca8k.c:422:37-43: ERROR: application of sizeof to pointer
>>>
>>> sizeof when applied to a pointer typed expression gives the size of
>>> the pointer
>>>
>>> Generated by: scripts/coccinelle/misc/noderef.cocci
>>>
>>> Fixes: 90386223f44e ("net: dsa: qca8k: add support for larger read/write size with mgmt Ethernet")
>>> CC: Ansuel Smith <ansuelsmth@gmail.com>
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Signed-off-by: kernel test robot <lkp@intel.com>
>>
>>> qca8k.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> kbuild folks, would it be easy to switch to including full path here?
> It seems like our CI expects that and ignores this patch.
Hi Jakub,
Thanks for the advice, will change it.
Best Regards,
Rong Chen
>
>> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>
> Applied, thanks!
> _______________________________________________
> kbuild-all mailing list -- kbuild-all@lists.01.org
> To unsubscribe send an email to kbuild-all-leave@lists.01.org
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-11 6:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <202202100634.l8CtrpzE-lkp@intel.com>
2022-02-09 22:13 ` [PATCH] net: dsa: qca8k: fix noderef.cocci warnings kernel test robot
2022-02-10 3:30 ` Florian Fainelli
2022-02-10 18:59 ` Jakub Kicinski
2022-02-11 6:36 ` [kbuild-all] " Chen, Rong A
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).