* [PATCH] scsi: qla4xxx: Simplify judgement condition
@ 2021-04-14 12:17 Wan Jiabing
2021-05-11 3:25 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Wan Jiabing @ 2021-04-14 12:17 UTC (permalink / raw)
To: Nilesh Javali, Manish Rangankar, GR-QLogic-Storage-Upstream,
James E.J. Bottomley, Martin K. Petersen, linux-scsi,
linux-kernel
Cc: kael_w, Wan Jiabing
Fix the following coccicheck warning:
./drivers/scsi/qla4xxx/ql4_83xx.c:475:23-25: WARNING !A || A && B is
equivalent to !A || B
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
drivers/scsi/qla4xxx/ql4_83xx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/qla4xxx/ql4_83xx.c b/drivers/scsi/qla4xxx/ql4_83xx.c
index 5f56122f6664..db41d90a5b6e 100644
--- a/drivers/scsi/qla4xxx/ql4_83xx.c
+++ b/drivers/scsi/qla4xxx/ql4_83xx.c
@@ -472,8 +472,7 @@ int qla4_83xx_can_perform_reset(struct scsi_qla_host *ha)
} else if (device_map[i].device_type == ISCSI_CLASS) {
if (drv_active & (1 << device_map[i].func_num)) {
if (!iscsi_present ||
- (iscsi_present &&
- (iscsi_func_low > device_map[i].func_num)))
+ iscsi_func_low > device_map[i].func_num)
iscsi_func_low = device_map[i].func_num;
iscsi_present++;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: qla4xxx: Simplify judgement condition
2021-04-14 12:17 [PATCH] scsi: qla4xxx: Simplify judgement condition Wan Jiabing
@ 2021-05-11 3:25 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2021-05-11 3:25 UTC (permalink / raw)
To: GR-QLogic-Storage-Upstream, Manish Rangankar, Wan Jiabing,
James E.J. Bottomley, linux-scsi, linux-kernel, Nilesh Javali
Cc: Martin K . Petersen, kael_w
On Wed, 14 Apr 2021 20:17:26 +0800, Wan Jiabing wrote:
> Fix the following coccicheck warning:
>
> ./drivers/scsi/qla4xxx/ql4_83xx.c:475:23-25: WARNING !A || A && B is
> equivalent to !A || B
Applied to 5.14/scsi-queue, thanks!
[1/1] scsi: qla4xxx: Simplify judgement condition
https://git.kernel.org/mkp/scsi/c/ed26297d14b7
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-11 3:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-14 12:17 [PATCH] scsi: qla4xxx: Simplify judgement condition Wan Jiabing
2021-05-11 3:25 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).