* [PATCH] tools/bootconfig: Fix a build error accroding to undefined fallthrough
@ 2021-05-13 3:06 Masami Hiramatsu
2021-05-20 14:07 ` Masami Hiramatsu
0 siblings, 1 reply; 4+ messages in thread
From: Masami Hiramatsu @ 2021-05-13 3:06 UTC (permalink / raw)
To: Steven Rostedt; +Cc: Masami Hiramatsu, LKML, Ingo Molnar
Since the "fallthrough" is defined only in the kernel, building
lib/bootconfig.c as a part of user-space tools causes a build
error.
Add a dummy fallthrough to avoid the build error.
Cc: stable@vger.kernel.org
Fixes: 4c1ca831adb1 ("Revert "lib: Revert use of fallthrough pseudo-keyword in lib/"")
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
---
tools/bootconfig/include/linux/bootconfig.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tools/bootconfig/include/linux/bootconfig.h b/tools/bootconfig/include/linux/bootconfig.h
index 078cbd2ba651..de7f30f99af3 100644
--- a/tools/bootconfig/include/linux/bootconfig.h
+++ b/tools/bootconfig/include/linux/bootconfig.h
@@ -4,4 +4,8 @@
#include "../../../../include/linux/bootconfig.h"
+#ifndef fallthrough
+# define fallthrough
+#endif
+
#endif
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] tools/bootconfig: Fix a build error accroding to undefined fallthrough
2021-05-13 3:06 [PATCH] tools/bootconfig: Fix a build error accroding to undefined fallthrough Masami Hiramatsu
@ 2021-05-20 14:07 ` Masami Hiramatsu
2021-05-20 15:47 ` Steven Rostedt
0 siblings, 1 reply; 4+ messages in thread
From: Masami Hiramatsu @ 2021-05-20 14:07 UTC (permalink / raw)
To: Masami Hiramatsu; +Cc: Steven Rostedt, LKML, Ingo Molnar
Hi Steve,
Can you pick at least this fix since it is a critical bug?
Thank you,
On Thu, 13 May 2021 12:06:33 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:
> Since the "fallthrough" is defined only in the kernel, building
> lib/bootconfig.c as a part of user-space tools causes a build
> error.
>
> Add a dummy fallthrough to avoid the build error.
>
> Cc: stable@vger.kernel.org
> Fixes: 4c1ca831adb1 ("Revert "lib: Revert use of fallthrough pseudo-keyword in lib/"")
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
> tools/bootconfig/include/linux/bootconfig.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/bootconfig/include/linux/bootconfig.h b/tools/bootconfig/include/linux/bootconfig.h
> index 078cbd2ba651..de7f30f99af3 100644
> --- a/tools/bootconfig/include/linux/bootconfig.h
> +++ b/tools/bootconfig/include/linux/bootconfig.h
> @@ -4,4 +4,8 @@
>
> #include "../../../../include/linux/bootconfig.h"
>
> +#ifndef fallthrough
> +# define fallthrough
> +#endif
> +
> #endif
>
--
Masami Hiramatsu <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tools/bootconfig: Fix a build error accroding to undefined fallthrough
2021-05-20 14:07 ` Masami Hiramatsu
@ 2021-05-20 15:47 ` Steven Rostedt
2021-05-20 23:07 ` Masami Hiramatsu
0 siblings, 1 reply; 4+ messages in thread
From: Steven Rostedt @ 2021-05-20 15:47 UTC (permalink / raw)
To: Masami Hiramatsu; +Cc: LKML, Ingo Molnar
Yeah, I have it cued up too. Can it wait till next week?
--Steve
On May 20, 2021 10:07:38 AM EDT, Masami Hiramatsu <mhiramat@kernel.org> wrote:
>Hi Steve,
>
>Can you pick at least this fix since it is a critical bug?
>
>Thank you,
>
>On Thu, 13 May 2021 12:06:33 +0900
>Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
>> Since the "fallthrough" is defined only in the kernel, building
>> lib/bootconfig.c as a part of user-space tools causes a build
>> error.
>>
>> Add a dummy fallthrough to avoid the build error.
>>
>> Cc: stable@vger.kernel.org
>> Fixes: 4c1ca831adb1 ("Revert "lib: Revert use of fallthrough
>pseudo-keyword in lib/"")
>> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
>> ---
>> tools/bootconfig/include/linux/bootconfig.h | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/tools/bootconfig/include/linux/bootconfig.h
>b/tools/bootconfig/include/linux/bootconfig.h
>> index 078cbd2ba651..de7f30f99af3 100644
>> --- a/tools/bootconfig/include/linux/bootconfig.h
>> +++ b/tools/bootconfig/include/linux/bootconfig.h
>> @@ -4,4 +4,8 @@
>>
>> #include "../../../../include/linux/bootconfig.h"
>>
>> +#ifndef fallthrough
>> +# define fallthrough
>> +#endif
>> +
>> #endif
>>
--
Sent from my Android device with K-9 Mail. Please excuse my brevity and top posting.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tools/bootconfig: Fix a build error accroding to undefined fallthrough
2021-05-20 15:47 ` Steven Rostedt
@ 2021-05-20 23:07 ` Masami Hiramatsu
0 siblings, 0 replies; 4+ messages in thread
From: Masami Hiramatsu @ 2021-05-20 23:07 UTC (permalink / raw)
To: Steven Rostedt; +Cc: LKML, Ingo Molnar
On Thu, 20 May 2021 11:47:13 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> Yeah, I have it cued up too. Can it wait till next week?
Yes, of course. Sorry for interruption.
Thank you!
>
> --Steve
>
>
> On May 20, 2021 10:07:38 AM EDT, Masami Hiramatsu <mhiramat@kernel.org> wrote:
> >Hi Steve,
> >
> >Can you pick at least this fix since it is a critical bug?
> >
> >Thank you,
> >
> >On Thu, 13 May 2021 12:06:33 +0900
> >Masami Hiramatsu <mhiramat@kernel.org> wrote:
> >
> >> Since the "fallthrough" is defined only in the kernel, building
> >> lib/bootconfig.c as a part of user-space tools causes a build
> >> error.
> >>
> >> Add a dummy fallthrough to avoid the build error.
> >>
> >> Cc: stable@vger.kernel.org
> >> Fixes: 4c1ca831adb1 ("Revert "lib: Revert use of fallthrough
> >pseudo-keyword in lib/"")
> >> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> >> ---
> >> tools/bootconfig/include/linux/bootconfig.h | 4 ++++
> >> 1 file changed, 4 insertions(+)
> >>
> >> diff --git a/tools/bootconfig/include/linux/bootconfig.h
> >b/tools/bootconfig/include/linux/bootconfig.h
> >> index 078cbd2ba651..de7f30f99af3 100644
> >> --- a/tools/bootconfig/include/linux/bootconfig.h
> >> +++ b/tools/bootconfig/include/linux/bootconfig.h
> >> @@ -4,4 +4,8 @@
> >>
> >> #include "../../../../include/linux/bootconfig.h"
> >>
> >> +#ifndef fallthrough
> >> +# define fallthrough
> >> +#endif
> >> +
> >> #endif
> >>
>
> --
> Sent from my Android device with K-9 Mail. Please excuse my brevity and top posting.
--
Masami Hiramatsu <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-20 23:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-13 3:06 [PATCH] tools/bootconfig: Fix a build error accroding to undefined fallthrough Masami Hiramatsu
2021-05-20 14:07 ` Masami Hiramatsu
2021-05-20 15:47 ` Steven Rostedt
2021-05-20 23:07 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).