From: Guangbin Huang <huangguangbin2@huawei.com>
To: <davem@davemloft.net>, <kuba@kernel.org>, <xie.he.0141@gmail.com>,
<ms@dev.tdt.de>, <willemb@google.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<lipeng321@huawei.com>, <tanhuazhong@huawei.com>,
<huangguangbin2@huawei.com>
Subject: [PATCH V2 net-next 03/10] net: hdlc_fr: fix an code style issue about "foo* bar"
Date: Fri, 28 May 2021 08:12:42 +0800 [thread overview]
Message-ID: <1622160769-6678-4-git-send-email-huangguangbin2@huawei.com> (raw)
In-Reply-To: <1622160769-6678-1-git-send-email-huangguangbin2@huawei.com>
From: Peng Li <lipeng321@huawei.com>
Fix the checkpatch error as "foo* bar" and should be "foo *bar",
and "(foo*)" should be "(foo *)".
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
drivers/net/wan/hdlc_fr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wan/hdlc_fr.c b/drivers/net/wan/hdlc_fr.c
index 96e4a89..4a6172c 100644
--- a/drivers/net/wan/hdlc_fr.c
+++ b/drivers/net/wan/hdlc_fr.c
@@ -159,7 +159,7 @@ static inline void dlci_to_q922(u8 *hdr, u16 dlci)
hdr[1] = ((dlci << 4) & 0xF0) | 0x01;
}
-static inline struct frad_state* state(hdlc_device *hdlc)
+static inline struct frad_state *state(hdlc_device *hdlc)
{
return(struct frad_state *)(hdlc->state);
}
@@ -1090,7 +1090,7 @@ static int fr_add_pvc(struct net_device *frad, unsigned int dlci, int type)
dev->priv_flags &= ~IFF_TX_SKB_SHARING;
eth_hw_addr_random(dev);
} else {
- *(__be16*)dev->dev_addr = htons(dlci);
+ *(__be16 *)dev->dev_addr = htons(dlci);
dlci_to_q922(dev->broadcast, dlci);
}
dev->netdev_ops = &pvc_ops;
--
2.8.1
next prev parent reply other threads:[~2021-05-28 0:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 0:12 [PATCH V2 net-next 00/10] net: hdlc_fr: clean up some code style issues Guangbin Huang
2021-05-28 0:12 ` [PATCH V2 net-next 01/10] net: hdlc_fr: remove redundant blank lines Guangbin Huang
2021-05-28 0:12 ` [PATCH V2 net-next 02/10] net: hdlc_fr: add blank line after declarations Guangbin Huang
2021-05-28 0:12 ` Guangbin Huang [this message]
2021-05-28 0:12 ` [PATCH V2 net-next 04/10] net: hdlc_fr: add some required spaces Guangbin Huang
2021-05-28 0:12 ` [PATCH V2 net-next 05/10] net: hdlc_fr: move out assignment in if condition Guangbin Huang
2021-05-28 0:12 ` [PATCH V2 net-next 06/10] net: hdlc_fr: code indent use tabs where possible Guangbin Huang
2021-05-28 0:12 ` [PATCH V2 net-next 07/10] net: hdlc_fr: remove space after '!' Guangbin Huang
2021-05-28 0:12 ` [PATCH V2 net-next 08/10] net: hdlc_fr: add braces {} to all arms of the statement Guangbin Huang
2021-05-28 0:12 ` [PATCH V2 net-next 09/10] net: hdlc_fr: remove redundant braces {} Guangbin Huang
2021-05-28 0:12 ` [PATCH V2 net-next 10/10] net: hdlc_fr: remove unnecessary out of memory message Guangbin Huang
2021-05-28 21:20 ` [PATCH V2 net-next 00/10] net: hdlc_fr: clean up some code style issues patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1622160769-6678-4-git-send-email-huangguangbin2@huawei.com \
--to=huangguangbin2@huawei.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lipeng321@huawei.com \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
--cc=tanhuazhong@huawei.com \
--cc=willemb@google.com \
--cc=xie.he.0141@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).