Re: [PATCH] regulator: rt4801: Fix NULL pointer dereference if priv->enable_gpios is NULL

From: "cy_huang(黃啟原)" <cy_huang@richtek.com>
To: "axel.lin@ingics.com" <axel.lin@ingics.com>,
	"broonie@kernel.org" <broonie@kernel.org>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: rt4801: Fix NULL pointer dereference if priv->enable_gpios is NULL
Date: Thu, 3 Jun 2021 10:39:51 +0000	[thread overview]
Message-ID: <1622716791.1034.13.camel@richtek.com> (raw)
In-Reply-To: <20210603094944.1114156-1-axel.lin@ingics.com>

Hi, Axel:

Which case will cause this error? I'm not really sure.
But if devm_gpiod_get_array_optional will return null, then it must be check
earlier in probe function

        priv->enable_gpios = devm_gpiod_get_array_optional(&i2c->dev, "enable",
GPIOD_OUT_HIGH);
-       if (IS_ERR(priv->enable_gpios)) {+       if (IS_ERR_OR_NULL(priv->enable_gpios)) {

If so, this change will be more reasonable.
Cause in binding document, I already write the min item must be '1'.
************* Email Confidentiality Notice ********************

The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you!