* [PATCH net-next 0/9] net: lapbether: clean up some code style issues
@ 2021-06-09 9:39 Guangbin Huang
2021-06-09 9:39 ` [PATCH net-next 1/9] net: lapbether: remove redundant blank line Guangbin Huang
` (9 more replies)
0 siblings, 10 replies; 11+ messages in thread
From: Guangbin Huang @ 2021-06-09 9:39 UTC (permalink / raw)
To: davem, kuba, xie.he.0141, ms, willemb
Cc: netdev, linux-kernel, lipeng321, huangguangbin2
From: Peng Li <lipeng321@huawei.com>
This patchset clean up some code style issues.
Peng Li (9):
net: lapbether: remove redundant blank line
net: lapbether: add blank line after declarations
net: lapbether: move out assignment in if condition
net: lapbether: remove trailing whitespaces
net: lapbether: remove unnecessary out of memory message
net: lapbether: fix the comments style issue
net: lapbether: replace comparison to NULL with "lapbeth_get_x25_dev"
net: lapbether: fix the alignment issue
net: lapbether: fix the code style issue about line length
drivers/net/wan/lapbether.c | 65 +++++++++++++++++++++------------------------
1 file changed, 30 insertions(+), 35 deletions(-)
--
2.8.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH net-next 1/9] net: lapbether: remove redundant blank line
2021-06-09 9:39 [PATCH net-next 0/9] net: lapbether: clean up some code style issues Guangbin Huang
@ 2021-06-09 9:39 ` Guangbin Huang
2021-06-09 9:39 ` [PATCH net-next 2/9] net: lapbether: add blank line after declarations Guangbin Huang
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Guangbin Huang @ 2021-06-09 9:39 UTC (permalink / raw)
To: davem, kuba, xie.he.0141, ms, willemb
Cc: netdev, linux-kernel, lipeng321, huangguangbin2
From: Peng Li <lipeng321@huawei.com>
This patch the redundant blank line.
Signed-off-by: Peng Li <lipeng321@huawei.com>
---
drivers/net/wan/lapbether.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c
index 5964686..bb529ef 100644
--- a/drivers/net/wan/lapbether.c
+++ b/drivers/net/wan/lapbether.c
@@ -307,7 +307,6 @@ static int lapbeth_set_mac_address(struct net_device *dev, void *addr)
return 0;
}
-
static const struct lapb_register_struct lapbeth_callbacks = {
.connect_confirmation = lapbeth_connected,
.connect_indication = lapbeth_connected,
--
2.8.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH net-next 2/9] net: lapbether: add blank line after declarations
2021-06-09 9:39 [PATCH net-next 0/9] net: lapbether: clean up some code style issues Guangbin Huang
2021-06-09 9:39 ` [PATCH net-next 1/9] net: lapbether: remove redundant blank line Guangbin Huang
@ 2021-06-09 9:39 ` Guangbin Huang
2021-06-09 9:39 ` [PATCH net-next 3/9] net: lapbether: move out assignment in if condition Guangbin Huang
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Guangbin Huang @ 2021-06-09 9:39 UTC (permalink / raw)
To: davem, kuba, xie.he.0141, ms, willemb
Cc: netdev, linux-kernel, lipeng321, huangguangbin2
From: Peng Li <lipeng321@huawei.com>
This patch fixes the checkpatch error about missing a blank line
after declarations.
Signed-off-by: Peng Li <lipeng321@huawei.com>
---
drivers/net/wan/lapbether.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c
index bb529ef..b6aef7b 100644
--- a/drivers/net/wan/lapbether.c
+++ b/drivers/net/wan/lapbether.c
@@ -303,6 +303,7 @@ static void lapbeth_disconnected(struct net_device *dev, int reason)
static int lapbeth_set_mac_address(struct net_device *dev, void *addr)
{
struct sockaddr *sa = addr;
+
memcpy(dev->dev_addr, sa->sa_data, dev->addr_len);
return 0;
}
--
2.8.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH net-next 3/9] net: lapbether: move out assignment in if condition
2021-06-09 9:39 [PATCH net-next 0/9] net: lapbether: clean up some code style issues Guangbin Huang
2021-06-09 9:39 ` [PATCH net-next 1/9] net: lapbether: remove redundant blank line Guangbin Huang
2021-06-09 9:39 ` [PATCH net-next 2/9] net: lapbether: add blank line after declarations Guangbin Huang
@ 2021-06-09 9:39 ` Guangbin Huang
2021-06-09 9:39 ` [PATCH net-next 4/9] net: lapbether: remove trailing whitespaces Guangbin Huang
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Guangbin Huang @ 2021-06-09 9:39 UTC (permalink / raw)
To: davem, kuba, xie.he.0141, ms, willemb
Cc: netdev, linux-kernel, lipeng321, huangguangbin2
From: Peng Li <lipeng321@huawei.com>
Should not use assignment in if condition.
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
drivers/net/wan/lapbether.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c
index b6aef7b..e5ae043 100644
--- a/drivers/net/wan/lapbether.c
+++ b/drivers/net/wan/lapbether.c
@@ -116,7 +116,8 @@ static int lapbeth_rcv(struct sk_buff *skb, struct net_device *dev, struct packe
if (dev_net(dev) != &init_net)
goto drop;
- if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL)
+ skb = skb_share_check(skb, GFP_ATOMIC);
+ if (!skb)
return NET_RX_DROP;
if (!pskb_may_pull(skb, 2))
@@ -137,7 +138,8 @@ static int lapbeth_rcv(struct sk_buff *skb, struct net_device *dev, struct packe
skb_pull(skb, 2); /* Remove the length bytes */
skb_trim(skb, len); /* Set the length of the data */
- if ((err = lapb_data_received(lapbeth->axdev, skb)) != LAPB_OK) {
+ err = lapb_data_received(lapbeth->axdev, skb);
+ if (err != LAPB_OK) {
printk(KERN_DEBUG "lapbether: lapb_data_received err - %d\n", err);
goto drop_unlock;
}
@@ -219,7 +221,8 @@ static netdev_tx_t lapbeth_xmit(struct sk_buff *skb,
skb_pull(skb, 1);
- if ((err = lapb_data_request(dev, skb)) != LAPB_OK) {
+ err = lapb_data_request(dev, skb);
+ if (err != LAPB_OK) {
pr_err("lapb_data_request error - %d\n", err);
goto drop;
}
@@ -327,7 +330,8 @@ static int lapbeth_open(struct net_device *dev)
napi_enable(&lapbeth->napi);
- if ((err = lapb_register(dev, &lapbeth_callbacks)) != LAPB_OK) {
+ err = lapb_register(dev, &lapbeth_callbacks);
+ if (err != LAPB_OK) {
pr_err("lapb_register error: %d\n", err);
return -ENODEV;
}
@@ -348,7 +352,8 @@ static int lapbeth_close(struct net_device *dev)
lapbeth->up = false;
spin_unlock_bh(&lapbeth->up_lock);
- if ((err = lapb_unregister(dev)) != LAPB_OK)
+ err = lapb_unregister(dev);
+ if (err != LAPB_OK)
pr_err("lapb_unregister error: %d\n", err);
napi_disable(&lapbeth->napi);
--
2.8.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH net-next 4/9] net: lapbether: remove trailing whitespaces
2021-06-09 9:39 [PATCH net-next 0/9] net: lapbether: clean up some code style issues Guangbin Huang
` (2 preceding siblings ...)
2021-06-09 9:39 ` [PATCH net-next 3/9] net: lapbether: move out assignment in if condition Guangbin Huang
@ 2021-06-09 9:39 ` Guangbin Huang
2021-06-09 9:39 ` [PATCH net-next 5/9] net: lapbether: remove unnecessary out of memory message Guangbin Huang
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Guangbin Huang @ 2021-06-09 9:39 UTC (permalink / raw)
To: davem, kuba, xie.he.0141, ms, willemb
Cc: netdev, linux-kernel, lipeng321, huangguangbin2
From: Peng Li <lipeng321@huawei.com>
This patch removes trailing whitespaces.
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
drivers/net/wan/lapbether.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c
index e5ae043..169b323 100644
--- a/drivers/net/wan/lapbether.c
+++ b/drivers/net/wan/lapbether.c
@@ -6,7 +6,7 @@
*
* This is a "pseudo" network driver to allow LAPB over Ethernet.
*
- * This driver can use any ethernet destination address, and can be
+ * This driver can use any ethernet destination address, and can be
* limited to accept frames from one dedicated ethernet card only.
*
* History
@@ -72,7 +72,7 @@ static struct lapbethdev *lapbeth_get_x25_dev(struct net_device *dev)
struct lapbethdev *lapbeth;
list_for_each_entry_rcu(lapbeth, &lapbeth_devices, node, lockdep_rtnl_is_held()) {
- if (lapbeth->ethdev == dev)
+ if (lapbeth->ethdev == dev)
return lapbeth;
}
return NULL;
@@ -468,7 +468,7 @@ static int lapbeth_device_event(struct notifier_block *this,
case NETDEV_GOING_DOWN:
/* ethernet device closes -> close LAPB interface */
lapbeth = lapbeth_get_x25_dev(dev);
- if (lapbeth)
+ if (lapbeth)
dev_close(lapbeth->axdev);
break;
case NETDEV_UNREGISTER:
--
2.8.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH net-next 5/9] net: lapbether: remove unnecessary out of memory message
2021-06-09 9:39 [PATCH net-next 0/9] net: lapbether: clean up some code style issues Guangbin Huang
` (3 preceding siblings ...)
2021-06-09 9:39 ` [PATCH net-next 4/9] net: lapbether: remove trailing whitespaces Guangbin Huang
@ 2021-06-09 9:39 ` Guangbin Huang
2021-06-09 9:39 ` [PATCH net-next 6/9] net: lapbether: fix the comments style issue Guangbin Huang
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Guangbin Huang @ 2021-06-09 9:39 UTC (permalink / raw)
To: davem, kuba, xie.he.0141, ms, willemb
Cc: netdev, linux-kernel, lipeng321, huangguangbin2
From: Peng Li <lipeng321@huawei.com>
This patch removes unnecessary out of memory message,
to fix the following checkpatch.pl warning:
"WARNING: Possible unnecessary 'out of memory' message"
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
drivers/net/wan/lapbether.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c
index 169b323..705a898 100644
--- a/drivers/net/wan/lapbether.c
+++ b/drivers/net/wan/lapbether.c
@@ -266,10 +266,8 @@ static void lapbeth_connected(struct net_device *dev, int reason)
unsigned char *ptr;
struct sk_buff *skb = __dev_alloc_skb(1, GFP_ATOMIC | __GFP_NOMEMALLOC);
- if (!skb) {
- pr_err("out of memory\n");
+ if (!skb)
return;
- }
ptr = skb_put(skb, 1);
*ptr = X25_IFACE_CONNECT;
@@ -286,10 +284,8 @@ static void lapbeth_disconnected(struct net_device *dev, int reason)
unsigned char *ptr;
struct sk_buff *skb = __dev_alloc_skb(1, GFP_ATOMIC | __GFP_NOMEMALLOC);
- if (!skb) {
- pr_err("out of memory\n");
+ if (!skb)
return;
- }
ptr = skb_put(skb, 1);
*ptr = X25_IFACE_DISCONNECT;
--
2.8.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH net-next 6/9] net: lapbether: fix the comments style issue
2021-06-09 9:39 [PATCH net-next 0/9] net: lapbether: clean up some code style issues Guangbin Huang
` (4 preceding siblings ...)
2021-06-09 9:39 ` [PATCH net-next 5/9] net: lapbether: remove unnecessary out of memory message Guangbin Huang
@ 2021-06-09 9:39 ` Guangbin Huang
2021-06-09 9:39 ` [PATCH net-next 7/9] net: lapbether: replace comparison to NULL with "lapbeth_get_x25_dev" Guangbin Huang
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Guangbin Huang @ 2021-06-09 9:39 UTC (permalink / raw)
To: davem, kuba, xie.he.0141, ms, willemb
Cc: netdev, linux-kernel, lipeng321, huangguangbin2
From: Peng Li <lipeng321@huawei.com>
Networking block comments don't use an empty /* line,
use /* Comment...
Block comments use * on subsequent lines.
Block comments use a trailing */ on a separate line.
This patch fixes the comments style issues.
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
drivers/net/wan/lapbether.c | 27 ++++++++++-----------------
1 file changed, 10 insertions(+), 17 deletions(-)
diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c
index 705a898..60628aa 100644
--- a/drivers/net/wan/lapbether.c
+++ b/drivers/net/wan/lapbether.c
@@ -44,7 +44,8 @@
static const u8 bcast_addr[6] = { 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF };
/* If this number is made larger, check that the temporary string buffer
- * in lapbeth_new_device is large enough to store the probe device name.*/
+ * in lapbeth_new_device is large enough to store the probe device name.
+ */
#define MAXLAPBDEV 100
struct lapbethdev {
@@ -64,8 +65,7 @@ static void lapbeth_disconnected(struct net_device *dev, int reason);
/* ------------------------------------------------------------------------ */
-/*
- * Get the LAPB device for the ethernet device
+/* Get the LAPB device for the ethernet device
*/
static struct lapbethdev *lapbeth_get_x25_dev(struct net_device *dev)
{
@@ -105,8 +105,7 @@ static int lapbeth_napi_poll(struct napi_struct *napi, int budget)
return processed;
}
-/*
- * Receive a LAPB frame via an ethernet interface.
+/* Receive a LAPB frame via an ethernet interface.
*/
static int lapbeth_rcv(struct sk_buff *skb, struct net_device *dev, struct packet_type *ptype, struct net_device *orig_dev)
{
@@ -179,8 +178,7 @@ static int lapbeth_data_indication(struct net_device *dev, struct sk_buff *skb)
return NET_RX_SUCCESS;
}
-/*
- * Send a LAPB frame via an ethernet interface
+/* Send a LAPB frame via an ethernet interface
*/
static netdev_tx_t lapbeth_xmit(struct sk_buff *skb,
struct net_device *dev)
@@ -296,8 +294,7 @@ static void lapbeth_disconnected(struct net_device *dev, int reason)
napi_schedule(&lapbeth->napi);
}
-/*
- * Set AX.25 callsign
+/* Set AX.25 callsign
*/
static int lapbeth_set_mac_address(struct net_device *dev, void *addr)
{
@@ -316,8 +313,7 @@ static const struct lapb_register_struct lapbeth_callbacks = {
.data_transmit = lapbeth_data_transmit,
};
-/*
- * open/close a device
+/* open/close a device
*/
static int lapbeth_open(struct net_device *dev)
{
@@ -376,8 +372,7 @@ static void lapbeth_setup(struct net_device *dev)
dev->addr_len = 0;
}
-/*
- * Setup a new device.
+/* Setup a new device.
*/
static int lapbeth_new_device(struct net_device *dev)
{
@@ -428,8 +423,7 @@ static int lapbeth_new_device(struct net_device *dev)
goto out;
}
-/*
- * Free a lapb network device.
+/* Free a lapb network device.
*/
static void lapbeth_free_device(struct lapbethdev *lapbeth)
{
@@ -438,8 +432,7 @@ static void lapbeth_free_device(struct lapbethdev *lapbeth)
unregister_netdevice(lapbeth->axdev);
}
-/*
- * Handle device status changes.
+/* Handle device status changes.
*
* Called from notifier with RTNL held.
*/
--
2.8.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH net-next 7/9] net: lapbether: replace comparison to NULL with "lapbeth_get_x25_dev"
2021-06-09 9:39 [PATCH net-next 0/9] net: lapbether: clean up some code style issues Guangbin Huang
` (5 preceding siblings ...)
2021-06-09 9:39 ` [PATCH net-next 6/9] net: lapbether: fix the comments style issue Guangbin Huang
@ 2021-06-09 9:39 ` Guangbin Huang
2021-06-09 9:39 ` [PATCH net-next 8/9] net: lapbether: fix the alignment issue Guangbin Huang
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Guangbin Huang @ 2021-06-09 9:39 UTC (permalink / raw)
To: davem, kuba, xie.he.0141, ms, willemb
Cc: netdev, linux-kernel, lipeng321, huangguangbin2
From: Peng Li <lipeng321@huawei.com>
According to the chackpatch.pl, comparison to NULL could
be written "lapbeth_get_x25_dev".
Signed-off-by: Peng Li <lipeng321@huawei.com>
---
drivers/net/wan/lapbether.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c
index 60628aa..74694af 100644
--- a/drivers/net/wan/lapbether.c
+++ b/drivers/net/wan/lapbether.c
@@ -451,7 +451,7 @@ static int lapbeth_device_event(struct notifier_block *this,
switch (event) {
case NETDEV_UP:
/* New ethernet device -> new LAPB interface */
- if (lapbeth_get_x25_dev(dev) == NULL)
+ if (!lapbeth_get_x25_dev(dev))
lapbeth_new_device(dev);
break;
case NETDEV_GOING_DOWN:
--
2.8.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH net-next 8/9] net: lapbether: fix the alignment issue
2021-06-09 9:39 [PATCH net-next 0/9] net: lapbether: clean up some code style issues Guangbin Huang
` (6 preceding siblings ...)
2021-06-09 9:39 ` [PATCH net-next 7/9] net: lapbether: replace comparison to NULL with "lapbeth_get_x25_dev" Guangbin Huang
@ 2021-06-09 9:39 ` Guangbin Huang
2021-06-09 9:39 ` [PATCH net-next 9/9] net: lapbether: fix the code style issue about line length Guangbin Huang
2021-06-09 21:20 ` [PATCH net-next 0/9] net: lapbether: clean up some code style issues patchwork-bot+netdevbpf
9 siblings, 0 replies; 11+ messages in thread
From: Guangbin Huang @ 2021-06-09 9:39 UTC (permalink / raw)
To: davem, kuba, xie.he.0141, ms, willemb
Cc: netdev, linux-kernel, lipeng321, huangguangbin2
From: Peng Li <lipeng321@huawei.com>
Alignment should match open parenthesis.
Signed-off-by: Peng Li <lipeng321@huawei.com>
---
drivers/net/wan/lapbether.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c
index 74694af..47ffb3c 100644
--- a/drivers/net/wan/lapbether.c
+++ b/drivers/net/wan/lapbether.c
@@ -181,7 +181,7 @@ static int lapbeth_data_indication(struct net_device *dev, struct sk_buff *skb)
/* Send a LAPB frame via an ethernet interface
*/
static netdev_tx_t lapbeth_xmit(struct sk_buff *skb,
- struct net_device *dev)
+ struct net_device *dev)
{
struct lapbethdev *lapbeth = netdev_priv(dev);
int err;
--
2.8.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH net-next 9/9] net: lapbether: fix the code style issue about line length
2021-06-09 9:39 [PATCH net-next 0/9] net: lapbether: clean up some code style issues Guangbin Huang
` (7 preceding siblings ...)
2021-06-09 9:39 ` [PATCH net-next 8/9] net: lapbether: fix the alignment issue Guangbin Huang
@ 2021-06-09 9:39 ` Guangbin Huang
2021-06-09 21:20 ` [PATCH net-next 0/9] net: lapbether: clean up some code style issues patchwork-bot+netdevbpf
9 siblings, 0 replies; 11+ messages in thread
From: Guangbin Huang @ 2021-06-09 9:39 UTC (permalink / raw)
To: davem, kuba, xie.he.0141, ms, willemb
Cc: netdev, linux-kernel, lipeng321, huangguangbin2
From: Peng Li <lipeng321@huawei.com>
According to the chackpatch.pl,
line length of 123 exceeds 100 columns, so fix it.
Signed-off-by: Peng Li <lipeng321@huawei.com>
---
drivers/net/wan/lapbether.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c
index 47ffb3c..89d31ad 100644
--- a/drivers/net/wan/lapbether.c
+++ b/drivers/net/wan/lapbether.c
@@ -107,7 +107,8 @@ static int lapbeth_napi_poll(struct napi_struct *napi, int budget)
/* Receive a LAPB frame via an ethernet interface.
*/
-static int lapbeth_rcv(struct sk_buff *skb, struct net_device *dev, struct packet_type *ptype, struct net_device *orig_dev)
+static int lapbeth_rcv(struct sk_buff *skb, struct net_device *dev,
+ struct packet_type *ptype, struct net_device *orig_dev)
{
int len, err;
struct lapbethdev *lapbeth;
--
2.8.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH net-next 0/9] net: lapbether: clean up some code style issues
2021-06-09 9:39 [PATCH net-next 0/9] net: lapbether: clean up some code style issues Guangbin Huang
` (8 preceding siblings ...)
2021-06-09 9:39 ` [PATCH net-next 9/9] net: lapbether: fix the code style issue about line length Guangbin Huang
@ 2021-06-09 21:20 ` patchwork-bot+netdevbpf
9 siblings, 0 replies; 11+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-06-09 21:20 UTC (permalink / raw)
To: Guangbin Huang
Cc: davem, kuba, xie.he.0141, ms, willemb, netdev, linux-kernel, lipeng321
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Wed, 9 Jun 2021 17:39:46 +0800 you wrote:
> From: Peng Li <lipeng321@huawei.com>
>
> This patchset clean up some code style issues.
>
> Peng Li (9):
> net: lapbether: remove redundant blank line
> net: lapbether: add blank line after declarations
> net: lapbether: move out assignment in if condition
> net: lapbether: remove trailing whitespaces
> net: lapbether: remove unnecessary out of memory message
> net: lapbether: fix the comments style issue
> net: lapbether: replace comparison to NULL with "lapbeth_get_x25_dev"
> net: lapbether: fix the alignment issue
> net: lapbether: fix the code style issue about line length
>
> [...]
Here is the summary with links:
- [net-next,1/9] net: lapbether: remove redundant blank line
https://git.kernel.org/netdev/net-next/c/eff57ab52cc4
- [net-next,2/9] net: lapbether: add blank line after declarations
https://git.kernel.org/netdev/net-next/c/5bc5f5f27b89
- [net-next,3/9] net: lapbether: move out assignment in if condition
https://git.kernel.org/netdev/net-next/c/a61bebc774cb
- [net-next,4/9] net: lapbether: remove trailing whitespaces
https://git.kernel.org/netdev/net-next/c/2e350780ae4f
- [net-next,5/9] net: lapbether: remove unnecessary out of memory message
https://git.kernel.org/netdev/net-next/c/d5e686e8b66d
- [net-next,6/9] net: lapbether: fix the comments style issue
https://git.kernel.org/netdev/net-next/c/4f9893c762f8
- [net-next,7/9] net: lapbether: replace comparison to NULL with "lapbeth_get_x25_dev"
https://git.kernel.org/netdev/net-next/c/d49859601d72
- [net-next,8/9] net: lapbether: fix the alignment issue
https://git.kernel.org/netdev/net-next/c/c564c049a34f
- [net-next,9/9] net: lapbether: fix the code style issue about line length
https://git.kernel.org/netdev/net-next/c/63a2bb15fe59
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-06-09 21:20 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-09 9:39 [PATCH net-next 0/9] net: lapbether: clean up some code style issues Guangbin Huang
2021-06-09 9:39 ` [PATCH net-next 1/9] net: lapbether: remove redundant blank line Guangbin Huang
2021-06-09 9:39 ` [PATCH net-next 2/9] net: lapbether: add blank line after declarations Guangbin Huang
2021-06-09 9:39 ` [PATCH net-next 3/9] net: lapbether: move out assignment in if condition Guangbin Huang
2021-06-09 9:39 ` [PATCH net-next 4/9] net: lapbether: remove trailing whitespaces Guangbin Huang
2021-06-09 9:39 ` [PATCH net-next 5/9] net: lapbether: remove unnecessary out of memory message Guangbin Huang
2021-06-09 9:39 ` [PATCH net-next 6/9] net: lapbether: fix the comments style issue Guangbin Huang
2021-06-09 9:39 ` [PATCH net-next 7/9] net: lapbether: replace comparison to NULL with "lapbeth_get_x25_dev" Guangbin Huang
2021-06-09 9:39 ` [PATCH net-next 8/9] net: lapbether: fix the alignment issue Guangbin Huang
2021-06-09 9:39 ` [PATCH net-next 9/9] net: lapbether: fix the code style issue about line length Guangbin Huang
2021-06-09 21:20 ` [PATCH net-next 0/9] net: lapbether: clean up some code style issues patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).