From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Li Yang <leoyang.li@nxp.com>,
Dipen Dudhat <Dipen.Dudhat@freescale.com>,
Prabhakar Kushwaha <prabhakar@freescale.com>,
linux-kernel@vger.kernel.org, Liu Shuo <b35362@freescale.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [RFT PATCH v2 1/2] memory: fsl_ifc: fix leaking IO mapping on probe failure
Date: Thu, 10 Jun 2021 09:27:10 +0200 [thread overview]
Message-ID: <162331002598.10998.10200143130121848334.b4-ty@canonical.com> (raw)
In-Reply-To: <20210527154322.81253-1-krzysztof.kozlowski@canonical.com>
On Thu, 27 May 2021 11:43:21 -0400, Krzysztof Kozlowski wrote:
> On probe error the driver should unmap the IO memory. Smatch reports:
>
> drivers/memory/fsl_ifc.c:298 fsl_ifc_ctrl_probe() warn: 'fsl_ifc_ctrl_dev->gregs' not released on lines: 298.
Applied, thanks!
[1/2] memory: fsl_ifc: fix leaking IO mapping on probe failure
commit: 3b132ab67fc7a358fff35e808fa65d4bea452521
[2/2] memory: fsl_ifc: fix leak of private memory on probe failure
commit: 8e0d09b1232d0538066c40ed4c13086faccbdff6
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
prev parent reply other threads:[~2021-06-10 7:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 15:43 [RFT PATCH v2 1/2] memory: fsl_ifc: fix leaking IO mapping on probe failure Krzysztof Kozlowski
2021-05-27 15:43 ` [RFT PATCH v2 2/2] memory: fsl_ifc: fix leak of private memory " Krzysztof Kozlowski
2021-06-10 7:27 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162331002598.10998.10200143130121848334.b4-ty@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=Dipen.Dudhat@freescale.com \
--cc=b35362@freescale.com \
--cc=dan.carpenter@oracle.com \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=prabhakar@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).