From: Guangbin Huang <huangguangbin2@huawei.com>
To: <davem@davemloft.net>, <kuba@kernel.org>, <xie.he.0141@gmail.com>,
<ms@dev.tdt.de>, <willemb@google.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<lipeng321@huawei.com>, <huangguangbin2@huawei.com>
Subject: [PATCH net-next 4/8] net: pc300too: move out assignment in if condition
Date: Fri, 11 Jun 2021 11:36:18 +0800 [thread overview]
Message-ID: <1623382582-37854-5-git-send-email-huangguangbin2@huawei.com> (raw)
In-Reply-To: <1623382582-37854-1-git-send-email-huangguangbin2@huawei.com>
From: Peng Li <lipeng321@huawei.com>
Should not use assignment in if condition.
Signed-off-by: Peng Li <lipeng321@huawei.com>
---
drivers/net/wan/pc300too.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wan/pc300too.c b/drivers/net/wan/pc300too.c
index 17d5cb8..7d8eae5 100644
--- a/drivers/net/wan/pc300too.c
+++ b/drivers/net/wan/pc300too.c
@@ -349,12 +349,14 @@ static int pc300_pci_init_one(struct pci_dev *pdev,
else
card->n_ports = 2;
- for (i = 0; i < card->n_ports; i++)
- if (!(card->ports[i].netdev = alloc_hdlcdev(&card->ports[i]))) {
+ for (i = 0; i < card->n_ports; i++) {
+ card->ports[i].netdev = alloc_hdlcdev(&card->ports[i]);
+ if (!card->ports[i].netdev) {
pr_err("unable to allocate memory\n");
pc300_pci_remove_one(pdev);
return -ENOMEM;
}
+ }
/* Reset PLX */
p = &card->plxbase->init_ctrl;
--
2.8.1
next prev parent reply other threads:[~2021-06-11 3:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 3:36 [PATCH net-next 0/8] net: pc300too: clean up some code style issues Guangbin Huang
2021-06-11 3:36 ` [PATCH net-next 1/8] net: pc300too: remove redundant blank lines Guangbin Huang
2021-06-11 3:36 ` [PATCH net-next 2/8] net: pc300too: add blank line after declarations Guangbin Huang
2021-06-11 3:36 ` [PATCH net-next 3/8] net: pc300too: fix the code style issue about "foo * bar" Guangbin Huang
2021-06-11 3:36 ` Guangbin Huang [this message]
2021-06-11 3:36 ` [PATCH net-next 5/8] net: pc300too: remove redundant initialization for statics Guangbin Huang
2021-06-11 3:36 ` [PATCH net-next 6/8] net: pc300too: replace comparison to NULL with "!card->plxbase" Guangbin Huang
2021-06-11 3:36 ` [PATCH net-next 7/8] net: pc300too: add some required spaces Guangbin Huang
2021-06-11 3:36 ` [PATCH net-next 8/8] net: pc300too: fix the comments style issue Guangbin Huang
2021-06-11 20:00 ` [PATCH net-next 0/8] net: pc300too: clean up some code style issues patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1623382582-37854-5-git-send-email-huangguangbin2@huawei.com \
--to=huangguangbin2@huawei.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lipeng321@huawei.com \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
--cc=xie.he.0141@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).