On Tue, 15 Jun 2021 01:15:36 +0800, 周琰杰 (Zhou Yanjie) wrote: > Add the dwmac bindings for the JZ4775 SoC, the X1000 SoC, > the X1600 SoC, the X1830 SoC and the X2000 SoC from Ingenic. > > Signed-off-by: 周琰杰 (Zhou Yanjie) > --- > > Notes: > v1->v2: > No change. > > v2->v3: > Add "ingenic,mac.yaml" for Ingenic SoCs. > > .../devicetree/bindings/net/ingenic,mac.yaml | 76 ++++++++++++++++++++++ > .../devicetree/bindings/net/snps,dwmac.yaml | 15 +++++ > 2 files changed, 91 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/ingenic,mac.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ingenic,mac.example.dt.yaml: ethernet@134b0000: compatible: ['ingenic,x1000-mac', 'snps,dwmac'] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ingenic,mac.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ingenic,mac.example.dt.yaml: ethernet@134b0000: compatible: Additional items are not allowed ('snps,dwmac' was unexpected) From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ingenic,mac.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ingenic,mac.example.dt.yaml: ethernet@134b0000: 'phy-mode' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/snps,dwmac.yaml \ndoc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1491797 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.