From: Zou Wei <zou_wei@huawei.com>
To: <stanley.chu@mediatek.com>, <alim.akhtar@samsung.com>,
<avri.altman@wdc.com>, <jejb@linux.ibm.com>,
<martin.petersen@oracle.com>, <matthias.bgg@gmail.com>
Cc: <linux-scsi@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
"Zou Wei" <zou_wei@huawei.com>
Subject: [PATCH -next] scsi: ufs-mediatek: Add missing of_node_put() in ufs_mtk_probe()
Date: Thu, 17 Jun 2021 19:32:02 +0800 [thread overview]
Message-ID: <1623929522-4389-1-git-send-email-zou_wei@huawei.com> (raw)
The function is missing a of_node_put on node, fix this by adding the call
before returning.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
drivers/scsi/ufs/ufs-mediatek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index 1a517c9..d2c2516 100644
--- a/drivers/scsi/ufs/ufs-mediatek.c
+++ b/drivers/scsi/ufs/ufs-mediatek.c
@@ -1120,6 +1120,7 @@ static int ufs_mtk_probe(struct platform_device *pdev)
if (err)
dev_info(dev, "probe failed %d\n", err);
+ of_node_put(reset_node);
return err;
}
--
2.6.2
next reply other threads:[~2021-06-17 11:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 11:32 Zou Wei [this message]
2021-06-18 1:16 ` [PATCH -next] scsi: ufs-mediatek: Add missing of_node_put() in ufs_mtk_probe() Stanley Chu
2021-06-19 2:48 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1623929522-4389-1-git-send-email-zou_wei@huawei.com \
--to=zou_wei@huawei.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=jejb@linux.ibm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).