* [PATCH -next] powerpc/spider-pci: Remove set but not used variable 'val'
@ 2021-06-01 8:53 Baokun Li
2021-06-15 2:00 ` libaokun (A)
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Baokun Li @ 2021-06-01 8:53 UTC (permalink / raw)
To: arnd, mpe, benh, paulus, linuxppc-dev, linux-kernel
Cc: weiyongjun1, yuehaibing, yangjihong1, yukuai3, libaokun1
Fixes gcc '-Wunused-but-set-variable' warning:
arch/powerpc/platforms/cell/spider-pci.c: In function 'spiderpci_io_flush':
arch/powerpc/platforms/cell/spider-pci.c:28:6: warning:
variable ‘val’ set but not used [-Wunused-but-set-variable]
It never used since introduction.
Signed-off-by: Baokun Li <libaokun1@huawei.com>
---
arch/powerpc/platforms/cell/spider-pci.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/powerpc/platforms/cell/spider-pci.c b/arch/powerpc/platforms/cell/spider-pci.c
index 93ea41680f54..a1c293f42a1f 100644
--- a/arch/powerpc/platforms/cell/spider-pci.c
+++ b/arch/powerpc/platforms/cell/spider-pci.c
@@ -25,10 +25,9 @@ struct spiderpci_iowa_private {
static void spiderpci_io_flush(struct iowa_bus *bus)
{
struct spiderpci_iowa_private *priv;
- u32 val;
priv = bus->private;
- val = in_be32(priv->regs + SPIDER_PCI_DUMMY_READ);
+ in_be32(priv->regs + SPIDER_PCI_DUMMY_READ);
iosync();
}
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] powerpc/spider-pci: Remove set but not used variable 'val'
2021-06-01 8:53 [PATCH -next] powerpc/spider-pci: Remove set but not used variable 'val' Baokun Li
@ 2021-06-15 2:00 ` libaokun (A)
2021-06-15 8:18 ` Arnd Bergmann
2021-06-18 3:51 ` Michael Ellerman
2 siblings, 0 replies; 4+ messages in thread
From: libaokun (A) @ 2021-06-15 2:00 UTC (permalink / raw)
To: arnd, mpe, benh, paulus, linuxppc-dev, linux-kernel
Cc: weiyongjun1, yuehaibing, yangjihong1, yukuai3
ping
在 2021/6/1 16:53, Baokun Li 写道:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> arch/powerpc/platforms/cell/spider-pci.c: In function 'spiderpci_io_flush':
> arch/powerpc/platforms/cell/spider-pci.c:28:6: warning:
> variable ‘val’ set but not used [-Wunused-but-set-variable]
>
> It never used since introduction.
>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> ---
> arch/powerpc/platforms/cell/spider-pci.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/cell/spider-pci.c b/arch/powerpc/platforms/cell/spider-pci.c
> index 93ea41680f54..a1c293f42a1f 100644
> --- a/arch/powerpc/platforms/cell/spider-pci.c
> +++ b/arch/powerpc/platforms/cell/spider-pci.c
> @@ -25,10 +25,9 @@ struct spiderpci_iowa_private {
> static void spiderpci_io_flush(struct iowa_bus *bus)
> {
> struct spiderpci_iowa_private *priv;
> - u32 val;
>
> priv = bus->private;
> - val = in_be32(priv->regs + SPIDER_PCI_DUMMY_READ);
> + in_be32(priv->regs + SPIDER_PCI_DUMMY_READ);
> iosync();
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] powerpc/spider-pci: Remove set but not used variable 'val'
2021-06-01 8:53 [PATCH -next] powerpc/spider-pci: Remove set but not used variable 'val' Baokun Li
2021-06-15 2:00 ` libaokun (A)
@ 2021-06-15 8:18 ` Arnd Bergmann
2021-06-18 3:51 ` Michael Ellerman
2 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2021-06-15 8:18 UTC (permalink / raw)
To: Baokun Li
Cc: Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras,
linuxppc-dev, Linux Kernel Mailing List, Wei Yongjun, YueHaibing,
yangjihong1, Yu Kuai
On Tue, Jun 1, 2021 at 10:53 AM Baokun Li <libaokun1@huawei.com> wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> arch/powerpc/platforms/cell/spider-pci.c: In function 'spiderpci_io_flush':
> arch/powerpc/platforms/cell/spider-pci.c:28:6: warning:
> variable ‘val’ set but not used [-Wunused-but-set-variable]
>
> It never used since introduction.
>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
LGTM
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] powerpc/spider-pci: Remove set but not used variable 'val'
2021-06-01 8:53 [PATCH -next] powerpc/spider-pci: Remove set but not used variable 'val' Baokun Li
2021-06-15 2:00 ` libaokun (A)
2021-06-15 8:18 ` Arnd Bergmann
@ 2021-06-18 3:51 ` Michael Ellerman
2 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2021-06-18 3:51 UTC (permalink / raw)
To: linuxppc-dev, paulus, arnd, mpe, benh, linux-kernel, Baokun Li
Cc: yuehaibing, yangjihong1, yukuai3, weiyongjun1
On Tue, 1 Jun 2021 16:53:19 +0800, Baokun Li wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> arch/powerpc/platforms/cell/spider-pci.c: In function 'spiderpci_io_flush':
> arch/powerpc/platforms/cell/spider-pci.c:28:6: warning:
> variable ‘val’ set but not used [-Wunused-but-set-variable]
>
> It never used since introduction.
Applied to powerpc/next.
[1/1] powerpc/spider-pci: Remove set but not used variable 'val'
https://git.kernel.org/powerpc/c/f377f7da26d2af87e2ddc39190546f62ecdb2bd8
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-18 4:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-01 8:53 [PATCH -next] powerpc/spider-pci: Remove set but not used variable 'val' Baokun Li
2021-06-15 2:00 ` libaokun (A)
2021-06-15 8:18 ` Arnd Bergmann
2021-06-18 3:51 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).