* [PATCH] rapidio: tsi721: handle errors properly inside tsi721_probe()
@ 2021-06-22 8:57 Zheyu Ma
0 siblings, 0 replies; only message in thread
From: Zheyu Ma @ 2021-06-22 8:57 UTC (permalink / raw)
To: mporter, alex.bou9; +Cc: linux-kernel, Zheyu Ma
BUG_on() is a too drastic measure, remove them. Instead, just output
error message and exit.
Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
---
drivers/rapidio/devices/tsi721.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/rapidio/devices/tsi721.c b/drivers/rapidio/devices/tsi721.c
index 4dd31dd9feea..92ec5081e5fb 100644
--- a/drivers/rapidio/devices/tsi721.c
+++ b/drivers/rapidio/devices/tsi721.c
@@ -2851,7 +2851,10 @@ static int tsi721_probe(struct pci_dev *pdev,
tsi_info(&pdev->dev, "Unable to set consistent DMA mask");
}
- BUG_ON(!pci_is_pcie(pdev));
+ if (!pci_is_pcie(pdev)) {
+ tsi_err(&pdev->dev, "Can't find PCI Express capability");
+ goto err_unmap_bars;
+ }
/* Clear "no snoop" and "relaxed ordering" bits. */
pcie_capability_clear_and_set_word(pdev, PCI_EXP_DEVCTL,
--
2.17.6
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-06-22 8:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-22 8:57 [PATCH] rapidio: tsi721: handle errors properly inside tsi721_probe() Zheyu Ma
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).