From: Stephen Boyd <sboyd@kernel.org>
To: Dmitry Osipenko <digetx@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Michael Turquette <mturquette@baylibre.com>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
Prashant Gaikwad <pgaikwad@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>,
Zhen Lei <thunder.leizhen@huawei.com>,
linux-clk <linux-clk@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-tegra <linux-tegra@vger.kernel.org>
Cc: Zhen Lei <thunder.leizhen@huawei.com>
Subject: Re: [PATCH 1/1] clk: tegra: tegra124-emc: Fix possible memory leak
Date: Fri, 25 Jun 2021 16:31:13 -0700 [thread overview]
Message-ID: <162466387362.3259633.2364843071785127818@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20210617082759.1008-1-thunder.leizhen@huawei.com>
Quoting Zhen Lei (2021-06-17 01:27:59)
> When krealloc() fails to expand the memory and returns NULL, the original
> memory is not released. In this case, the original "timings" scale should
> be maintained.
>
> Fixes: 888ca40e2843 ("clk: tegra: emc: Support multiple RAM codes")
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
Looks correct, but when does krealloc() return NULL? My read of the
kerneldoc is that it would return the original memory if the new
allocation "failed".
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
next prev parent reply other threads:[~2021-06-25 23:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 8:27 [PATCH 1/1] clk: tegra: tegra124-emc: Fix possible memory leak Zhen Lei
2021-06-25 23:31 ` Stephen Boyd [this message]
2021-06-26 1:32 ` Leizhen (ThunderTown)
2021-06-27 23:44 ` Stephen Boyd
2021-06-28 0:29 ` Dmitry Osipenko
2021-06-28 1:52 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162466387362.3259633.2364843071785127818@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).