From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 823EDC11F66 for ; Wed, 30 Jun 2021 18:18:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A6B461468 for ; Wed, 30 Jun 2021 18:18:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233051AbhF3SVH (ORCPT ); Wed, 30 Jun 2021 14:21:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:35182 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229991AbhF3SVE (ORCPT ); Wed, 30 Jun 2021 14:21:04 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id AC2C861159; Wed, 30 Jun 2021 18:18:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625077115; bh=k716vSAadTFPAw6m1tRKqa78k3IKWlFrre5nAMX7UdA=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=Y/hKntSLE5TI4906/U2vzFdLCRTQbzk/vWRznu2k+j45ON6XpwiU3x4AxsN33A5tb Rp3dVzD8Vs7Pb36uiQZo/q3H4lN7uyTxkcbOXSz/rNnVj2PtLRU+Q5qVrB7/bEPoOJ m9m0v74i2YLQPXliBCvVyqPaHnwg2tosh/eiPhZKwxJU8a822pA/tN/w9m8OwyJHbC NcT3cFZqahT7P+2tT9FY2BHlsn7syVST5NIzzWBakuH9ryPZtrhUBPuJxJhAnOvlks vfjK4iWyujIfrXKSV+QaP0UQPmnx9WlK4u28n3Xm5zxCUe5N/asuDv0jDJzq+krtck SrI4WO2lo5IpQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20210630020322.2555946-1-wanghai38@huawei.com> References: <20210630020322.2555946-1-wanghai38@huawei.com> Subject: Re: [PATCH -next] clk: lmk04832: fix return value check in lmk04832_probe() From: Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org To: Wang Hai , lvb@xiphos.com, mturquette@baylibre.com Date: Wed, 30 Jun 2021 11:18:34 -0700 Message-ID: <162507711455.3331010.7831190546024557147@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Wang Hai (2021-06-29 19:03:22) > In case of error, the function devm_kzalloc() and devm_kcalloc() return > NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check > should be replaced with NULL test. >=20 > Fixes: 3bc61cfd6f4a ("clk: add support for the lmk04832") > Reported-by: Hulk Robot > Signed-off-by: Wang Hai > --- Applied to clk-next