* [PATCH net-next] ipv6: remove unnecessary local variable
@ 2021-07-15 14:26 Rocco Yue
2021-07-15 17:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Rocco Yue @ 2021-07-15 14:26 UTC (permalink / raw)
To: David S . Miller, Hideaki YOSHIFUJI, David Ahern, Jakub Kicinski,
Matthias Brugger
Cc: netdev, linux-kernel, linux-arm-kernel, linux-mediatek,
wsd_upstream, rocco.yue, Rocco Yue
The local variable "struct net *net" in the two functions of
inet6_rtm_getaddr() and inet6_dump_addr() are actually useless,
so remove them.
Signed-off-by: Rocco Yue <rocco.yue@mediatek.com>
---
net/ipv6/addrconf.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 3bf685fe64b9..e2f625e39455 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -5211,8 +5211,7 @@ static int inet6_dump_addr(struct sk_buff *skb, struct netlink_callback *cb,
.netnsid = -1,
.type = type,
};
- struct net *net = sock_net(skb->sk);
- struct net *tgt_net = net;
+ struct net *tgt_net = sock_net(skb->sk);
int idx, s_idx, s_ip_idx;
int h, s_h;
struct net_device *dev;
@@ -5351,7 +5350,7 @@ static int inet6_rtm_valid_getaddr_req(struct sk_buff *skb,
static int inet6_rtm_getaddr(struct sk_buff *in_skb, struct nlmsghdr *nlh,
struct netlink_ext_ack *extack)
{
- struct net *net = sock_net(in_skb->sk);
+ struct net *tgt_net = sock_net(in_skb->sk);
struct inet6_fill_args fillargs = {
.portid = NETLINK_CB(in_skb).portid,
.seq = nlh->nlmsg_seq,
@@ -5359,7 +5358,6 @@ static int inet6_rtm_getaddr(struct sk_buff *in_skb, struct nlmsghdr *nlh,
.flags = 0,
.netnsid = -1,
};
- struct net *tgt_net = net;
struct ifaddrmsg *ifm;
struct nlattr *tb[IFA_MAX+1];
struct in6_addr *addr = NULL, *peer;
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] ipv6: remove unnecessary local variable
2021-07-15 14:26 [PATCH net-next] ipv6: remove unnecessary local variable Rocco Yue
@ 2021-07-15 17:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-07-15 17:30 UTC (permalink / raw)
To: Rocco Yue
Cc: davem, yoshfuji, dsahern, kuba, matthias.bgg, netdev,
linux-kernel, linux-arm-kernel, linux-mediatek, wsd_upstream,
rocco.yue
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Thu, 15 Jul 2021 22:26:43 +0800 you wrote:
> The local variable "struct net *net" in the two functions of
> inet6_rtm_getaddr() and inet6_dump_addr() are actually useless,
> so remove them.
>
> Signed-off-by: Rocco Yue <rocco.yue@mediatek.com>
> ---
> net/ipv6/addrconf.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Here is the summary with links:
- [net-next] ipv6: remove unnecessary local variable
https://git.kernel.org/netdev/net-next/c/87117baf4f92
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-15 17:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-15 14:26 [PATCH net-next] ipv6: remove unnecessary local variable Rocco Yue
2021-07-15 17:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).