linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: cy_huang <u0084500@gmail.com>
To: broonie@kernel.org
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
	axel.lin@ingics.com, ChiYuan Huang <cy_huang@richtek.com>
Subject: [PATCH] regulator: rtq6752: fix reg reset behavior
Date: Fri, 16 Jul 2021 11:55:46 +0800	[thread overview]
Message-ID: <1626407746-23156-1-git-send-email-u0084500@gmail.com> (raw)

From: ChiYuan Huang <cy_huang@richtek.com>

Reg will be reset in below two conditions.
1. 'Enable' pin from H to L.
2. Both PAVDD and NAVDD are all disabled.

And 'Enable' pin also control i2c communication capability.

This patch is to Seperate the if condition in enable/disable callback for
reg cache manipulation.

Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
---
Hi,
Normally, during testing, I consider only 'enable' will cause reg to be reset.
But after consulting our RD, this reset behavior not just 'Enable' H to L,
both powers are disabled, also.

This patch is used to fix this.
---
 drivers/regulator/rtq6752-regulator.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/regulator/rtq6752-regulator.c b/drivers/regulator/rtq6752-regulator.c
index 72a72aa..609d3fc 100644
--- a/drivers/regulator/rtq6752-regulator.c
+++ b/drivers/regulator/rtq6752-regulator.c
@@ -54,12 +54,14 @@ static int rtq6752_set_vdd_enable(struct regulator_dev *rdev)
 	int rid = rdev_get_id(rdev), ret;
 
 	mutex_lock(&priv->lock);
-	if (!priv->enable_flag && priv->enable_gpio) {
+	if (priv->enable_gpio) {
 		gpiod_set_value(priv->enable_gpio, 1);
 
 		usleep_range(RTQ6752_I2CRDY_TIMEUS,
 			     RTQ6752_I2CRDY_TIMEUS + 100);
+	}
 
+	if (!priv->enable_flag) {
 		regcache_cache_only(priv->regmap, false);
 		ret = regcache_sync(priv->regmap);
 		if (ret) {
@@ -86,12 +88,14 @@ static int rtq6752_set_vdd_disable(struct regulator_dev *rdev)
 	mutex_lock(&priv->lock);
 	priv->enable_flag &= ~BIT(rid);
 
-	if (!priv->enable_flag && priv->enable_gpio) {
+	if (!priv->enable_flag) {
 		regcache_cache_only(priv->regmap, true);
 		regcache_mark_dirty(priv->regmap);
+	}
 
+	if (priv->enable_gpio)
 		gpiod_set_value(priv->enable_gpio, 0);
-	}
+
 	mutex_unlock(&priv->lock);
 
 	return 0;
-- 
2.7.4


             reply	other threads:[~2021-07-16  3:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-16  3:55 cy_huang [this message]
2021-07-16 15:05 ` [PATCH] regulator: rtq6752: fix reg reset behavior Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1626407746-23156-1-git-send-email-u0084500@gmail.com \
    --to=u0084500@gmail.com \
    --cc=axel.lin@ingics.com \
    --cc=broonie@kernel.org \
    --cc=cy_huang@richtek.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).