linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] MAINTAINERS: Update for VMCI driver
@ 2021-07-20 10:25 Jorgen Hansen
  0 siblings, 0 replies; 8+ messages in thread
From: Jorgen Hansen @ 2021-07-20 10:25 UTC (permalink / raw)
  To: linux-kernel; +Cc: Jorgen Hansen

Add maintainer info for the VMware VMCI driver.

Signed-off-by: Jorgen Hansen <jhansen@vmware.com>
---
 MAINTAINERS | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index a61f4f3..7e7c6fa 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19792,6 +19792,14 @@ L:	netdev@vger.kernel.org
 S:	Supported
 F:	drivers/ptp/ptp_vmw.c
 
+VMWARE VMCI DRIVER
+M:	Jorgen Hansen <jhansen@vmware.com>
+M:	Vishnu Dasa <vdasa@vmware.com>
+M:	"VMware, Inc." <pv-drivers@vmware.com>
+L:	linux-kernel@vger.kernel.org
+S:	Maintained
+F:	drivers/misc/vmw_vmci/
+
 VMWARE VMMOUSE SUBDRIVER
 M:	"VMware Graphics" <linux-graphics-maintainer@vmware.com>
 M:	"VMware, Inc." <pv-drivers@vmware.com>
-- 
2.6.2


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] MAINTAINERS: Update for VMCI driver
  2021-07-21  9:26       ` Jorgen Hansen
@ 2021-07-21  9:33         ` Greg KH
  0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2021-07-21  9:33 UTC (permalink / raw)
  To: Jorgen Hansen; +Cc: linux-kernel, virtualization, Pv-drivers

On Wed, Jul 21, 2021 at 09:26:15AM +0000, Jorgen Hansen wrote:
> 
> 
> > On 21 Jul 2021, at 11:00, Greg KH <gregkh@linuxfoundation.org> wrote:
> > 
> > On Wed, Jul 21, 2021 at 08:46:15AM +0000, Jorgen Hansen wrote:
> >> 
> >> 
> >>> On 20 Jul 2021, at 12:39, Greg KH <gregkh@linuxfoundation.org> wrote:
> >>> 
> >>> On Tue, Jul 20, 2021 at 03:29:01AM -0700, Jorgen Hansen wrote:
> >>>> Add maintainer info for the VMware VMCI driver.
> >>>> 
> >>>> Signed-off-by: Jorgen Hansen <jhansen@vmware.com>
> >>>> ---
> >>>> MAINTAINERS | 8 ++++++++
> >>>> 1 file changed, 8 insertions(+)
> >>>> 
> >>>> diff --git a/MAINTAINERS b/MAINTAINERS
> >>>> index a61f4f3..7e7c6fa 100644
> >>>> --- a/MAINTAINERS
> >>>> +++ b/MAINTAINERS
> >>>> @@ -19792,6 +19792,14 @@ L:	netdev@vger.kernel.org
> >>>> S:	Supported
> >>>> F:	drivers/ptp/ptp_vmw.c
> >>>> 
> >>>> +VMWARE VMCI DRIVER
> >>>> +M:	Jorgen Hansen <jhansen@vmware.com>
> >>>> +M:	Vishnu Dasa <vdasa@vmware.com>
> >>>> +M:	"VMware, Inc." <pv-drivers@vmware.com>
> >>> 
> >>> Please do not use generic aliases as they provide no personal
> >>> responsibility.  Just stick with real people.
> >> 
> >> That makes sense. However, the pv-drivers list is used for keeping managers
> >> and people helping with testing in the loop. So would adding pv-drivers as a
> >> second L: entry be OK?
> > 
> > Is it really a list?  If not, then that would not make much sense.
> 
> It is - with VMware subscribers only but anyone can post to it. If the intent of the
> L: entries is to allow folks to subscribe to relevant information, then it isn’t
> appropriate.

Then mark it as a private list.

> All existing vmw driver maintainer entries have pv-drivers as an M: entry,
> so has there been a change in policy regarding this? The approach has
> been quite useful for us.

It's a hit-or-miss policy, some of us notice it, others do not.  nothing
official at all, just those of us with more experience know that aliases
like this usually atrophy and become useless.  There are many such
examples of useless ones in the MAINTAINERS file right now :(

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] MAINTAINERS: Update for VMCI driver
  2021-07-21  9:00     ` Greg KH
@ 2021-07-21  9:26       ` Jorgen Hansen
  2021-07-21  9:33         ` Greg KH
  0 siblings, 1 reply; 8+ messages in thread
From: Jorgen Hansen @ 2021-07-21  9:26 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-kernel, virtualization, Pv-drivers



> On 21 Jul 2021, at 11:00, Greg KH <gregkh@linuxfoundation.org> wrote:
> 
> On Wed, Jul 21, 2021 at 08:46:15AM +0000, Jorgen Hansen wrote:
>> 
>> 
>>> On 20 Jul 2021, at 12:39, Greg KH <gregkh@linuxfoundation.org> wrote:
>>> 
>>> On Tue, Jul 20, 2021 at 03:29:01AM -0700, Jorgen Hansen wrote:
>>>> Add maintainer info for the VMware VMCI driver.
>>>> 
>>>> Signed-off-by: Jorgen Hansen <jhansen@vmware.com>
>>>> ---
>>>> MAINTAINERS | 8 ++++++++
>>>> 1 file changed, 8 insertions(+)
>>>> 
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index a61f4f3..7e7c6fa 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -19792,6 +19792,14 @@ L:	netdev@vger.kernel.org
>>>> S:	Supported
>>>> F:	drivers/ptp/ptp_vmw.c
>>>> 
>>>> +VMWARE VMCI DRIVER
>>>> +M:	Jorgen Hansen <jhansen@vmware.com>
>>>> +M:	Vishnu Dasa <vdasa@vmware.com>
>>>> +M:	"VMware, Inc." <pv-drivers@vmware.com>
>>> 
>>> Please do not use generic aliases as they provide no personal
>>> responsibility.  Just stick with real people.
>> 
>> That makes sense. However, the pv-drivers list is used for keeping managers
>> and people helping with testing in the loop. So would adding pv-drivers as a
>> second L: entry be OK?
> 
> Is it really a list?  If not, then that would not make much sense.

It is - with VMware subscribers only but anyone can post to it. If the intent of the
L: entries is to allow folks to subscribe to relevant information, then it isn’t
appropriate.

All existing vmw driver maintainer entries have pv-drivers as an M: entry,
so has there been a change in policy regarding this? The approach has
been quite useful for us.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] MAINTAINERS: Update for VMCI driver
  2021-07-21  8:46   ` Jorgen Hansen
@ 2021-07-21  9:00     ` Greg KH
  2021-07-21  9:26       ` Jorgen Hansen
  0 siblings, 1 reply; 8+ messages in thread
From: Greg KH @ 2021-07-21  9:00 UTC (permalink / raw)
  To: Jorgen Hansen; +Cc: linux-kernel, virtualization, Pv-drivers

On Wed, Jul 21, 2021 at 08:46:15AM +0000, Jorgen Hansen wrote:
> 
> 
> > On 20 Jul 2021, at 12:39, Greg KH <gregkh@linuxfoundation.org> wrote:
> > 
> > On Tue, Jul 20, 2021 at 03:29:01AM -0700, Jorgen Hansen wrote:
> >> Add maintainer info for the VMware VMCI driver.
> >> 
> >> Signed-off-by: Jorgen Hansen <jhansen@vmware.com>
> >> ---
> >> MAINTAINERS | 8 ++++++++
> >> 1 file changed, 8 insertions(+)
> >> 
> >> diff --git a/MAINTAINERS b/MAINTAINERS
> >> index a61f4f3..7e7c6fa 100644
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> @@ -19792,6 +19792,14 @@ L:	netdev@vger.kernel.org
> >> S:	Supported
> >> F:	drivers/ptp/ptp_vmw.c
> >> 
> >> +VMWARE VMCI DRIVER
> >> +M:	Jorgen Hansen <jhansen@vmware.com>
> >> +M:	Vishnu Dasa <vdasa@vmware.com>
> >> +M:	"VMware, Inc." <pv-drivers@vmware.com>
> > 
> > Please do not use generic aliases as they provide no personal
> > responsibility.  Just stick with real people.
> 
> That makes sense. However, the pv-drivers list is used for keeping managers
> and people helping with testing in the loop. So would adding pv-drivers as a
> second L: entry be OK?

Is it really a list?  If not, then that would not make much sense.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] MAINTAINERS: Update for VMCI driver
  2021-07-20 10:39 ` Greg KH
       [not found]   ` <0DE37084-185C-4144-AF9E-22EC044B0CB5@vmware.com>
@ 2021-07-21  8:46   ` Jorgen Hansen
  2021-07-21  9:00     ` Greg KH
  1 sibling, 1 reply; 8+ messages in thread
From: Jorgen Hansen @ 2021-07-21  8:46 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-kernel, virtualization, Pv-drivers



> On 20 Jul 2021, at 12:39, Greg KH <gregkh@linuxfoundation.org> wrote:
> 
> On Tue, Jul 20, 2021 at 03:29:01AM -0700, Jorgen Hansen wrote:
>> Add maintainer info for the VMware VMCI driver.
>> 
>> Signed-off-by: Jorgen Hansen <jhansen@vmware.com>
>> ---
>> MAINTAINERS | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>> 
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index a61f4f3..7e7c6fa 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -19792,6 +19792,14 @@ L:	netdev@vger.kernel.org
>> S:	Supported
>> F:	drivers/ptp/ptp_vmw.c
>> 
>> +VMWARE VMCI DRIVER
>> +M:	Jorgen Hansen <jhansen@vmware.com>
>> +M:	Vishnu Dasa <vdasa@vmware.com>
>> +M:	"VMware, Inc." <pv-drivers@vmware.com>
> 
> Please do not use generic aliases as they provide no personal
> responsibility.  Just stick with real people.

That makes sense. However, the pv-drivers list is used for keeping managers
and people helping with testing in the loop. So would adding pv-drivers as a
second L: entry be OK?

Thanks,
Jorgen

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] MAINTAINERS: Update for VMCI driver
       [not found]   ` <0DE37084-185C-4144-AF9E-22EC044B0CB5@vmware.com>
@ 2021-07-20 18:11     ` Greg KH
  0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2021-07-20 18:11 UTC (permalink / raw)
  To: Vishnu Dasa; +Cc: Jorgen Hansen, linux-kernel, virtualization, Pv-drivers

On Tue, Jul 20, 2021 at 06:04:15PM +0000, Vishnu Dasa wrote:
> 
> On Jul 20, 2021, at 3:39 AM, Greg KH <gregkh@linuxfoundation.org<mailto:gregkh@linuxfoundation.org>> wrote:
> 
> Also I would need an ack from Vishnu.
> 
> Acked-by: Vishnu Dasa <vdasa@vmware.com<mailto:dasa@vmware.com>>

A maintainer that sends html email isn't going to work very well :(

Please fix.

greg k-h

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] MAINTAINERS: Update for VMCI driver
  2021-07-20 10:29 Jorgen Hansen
@ 2021-07-20 10:39 ` Greg KH
       [not found]   ` <0DE37084-185C-4144-AF9E-22EC044B0CB5@vmware.com>
  2021-07-21  8:46   ` Jorgen Hansen
  0 siblings, 2 replies; 8+ messages in thread
From: Greg KH @ 2021-07-20 10:39 UTC (permalink / raw)
  To: Jorgen Hansen; +Cc: linux-kernel, virtualization, pv-drivers

On Tue, Jul 20, 2021 at 03:29:01AM -0700, Jorgen Hansen wrote:
> Add maintainer info for the VMware VMCI driver.
> 
> Signed-off-by: Jorgen Hansen <jhansen@vmware.com>
> ---
>  MAINTAINERS | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index a61f4f3..7e7c6fa 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -19792,6 +19792,14 @@ L:	netdev@vger.kernel.org
>  S:	Supported
>  F:	drivers/ptp/ptp_vmw.c
>  
> +VMWARE VMCI DRIVER
> +M:	Jorgen Hansen <jhansen@vmware.com>
> +M:	Vishnu Dasa <vdasa@vmware.com>
> +M:	"VMware, Inc." <pv-drivers@vmware.com>

Please do not use generic aliases as they provide no personal
responsibility.  Just stick with real people.

Also I would need an ack from Vishnu.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] MAINTAINERS: Update for VMCI driver
@ 2021-07-20 10:29 Jorgen Hansen
  2021-07-20 10:39 ` Greg KH
  0 siblings, 1 reply; 8+ messages in thread
From: Jorgen Hansen @ 2021-07-20 10:29 UTC (permalink / raw)
  To: linux-kernel, virtualization; +Cc: gregkh, pv-drivers, Jorgen Hansen

Add maintainer info for the VMware VMCI driver.

Signed-off-by: Jorgen Hansen <jhansen@vmware.com>
---
 MAINTAINERS | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index a61f4f3..7e7c6fa 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19792,6 +19792,14 @@ L:	netdev@vger.kernel.org
 S:	Supported
 F:	drivers/ptp/ptp_vmw.c
 
+VMWARE VMCI DRIVER
+M:	Jorgen Hansen <jhansen@vmware.com>
+M:	Vishnu Dasa <vdasa@vmware.com>
+M:	"VMware, Inc." <pv-drivers@vmware.com>
+L:	linux-kernel@vger.kernel.org
+S:	Maintained
+F:	drivers/misc/vmw_vmci/
+
 VMWARE VMMOUSE SUBDRIVER
 M:	"VMware Graphics" <linux-graphics-maintainer@vmware.com>
 M:	"VMware, Inc." <pv-drivers@vmware.com>
-- 
2.6.2


^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-07-21  9:41 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-20 10:25 [PATCH] MAINTAINERS: Update for VMCI driver Jorgen Hansen
2021-07-20 10:29 Jorgen Hansen
2021-07-20 10:39 ` Greg KH
     [not found]   ` <0DE37084-185C-4144-AF9E-22EC044B0CB5@vmware.com>
2021-07-20 18:11     ` Greg KH
2021-07-21  8:46   ` Jorgen Hansen
2021-07-21  9:00     ` Greg KH
2021-07-21  9:26       ` Jorgen Hansen
2021-07-21  9:33         ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).