linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/2] add ethernet support to rk3568 dts
@ 2021-07-29  9:39 Michael Riesch
  2021-07-29  9:39 ` [PATCH v2 1/2] arm64: dts: rockchip: add gmac0 node to rk3568 Michael Riesch
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Michael Riesch @ 2021-07-29  9:39 UTC (permalink / raw)
  To: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
  Cc: Rob Herring, Heiko Stuebner, Liang Chen, Peter Geis,
	Michael Riesch, Simon Xue

Hi all,

these patches should be orthogonal to the ongoing work of Peter Geis
that aims to introduce the GMAC1 node to the common RK356x dts.
The GMAC0 node, which is exclusive to the RK3568, and the Ethernet
phy nodes in the RK3568 EVB1 are introduced by this series.

v2:
- sort properties alphabetically
- use phy-mode "rgmii-id" without delay properties
- rename phy nodes to "ethernet-phy"

Best regards,
Michael

Michael Riesch (2):
  arm64: dts: rockchip: add gmac0 node to rk3568
  arm64: dts: rockchip: rk3568-evb1-v10: add ethernet support

 .../boot/dts/rockchip/rk3568-evb1-v10.dts     | 57 +++++++++++++++++++
 arch/arm64/boot/dts/rockchip/rk3568.dtsi      | 49 ++++++++++++++++
 2 files changed, 106 insertions(+)

-- 
2.20.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2 1/2] arm64: dts: rockchip: add gmac0 node to rk3568
  2021-07-29  9:39 [PATCH v2 0/2] add ethernet support to rk3568 dts Michael Riesch
@ 2021-07-29  9:39 ` Michael Riesch
  2021-07-29  9:39 ` [PATCH v2 2/2] arm64: dts: rockchip: rk3568-evb1-v10: add ethernet support Michael Riesch
  2021-07-29 13:19 ` [PATCH v2 0/2] add ethernet support to rk3568 dts Heiko Stuebner
  2 siblings, 0 replies; 4+ messages in thread
From: Michael Riesch @ 2021-07-29  9:39 UTC (permalink / raw)
  To: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
  Cc: Rob Herring, Heiko Stuebner, Liang Chen, Peter Geis,
	Michael Riesch, Simon Xue

While both RK3566 and RK3568 feature the gmac1 node, the gmac0
node is exclusive to the RK3568.

Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
---
v2:
- sort properties alphabetically

 arch/arm64/boot/dts/rockchip/rk3568.dtsi | 49 ++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3568.dtsi b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
index da01a59f6f26..2fd313a295f8 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
@@ -22,6 +22,55 @@
 		compatible = "rockchip,rk3568-qos", "syscon";
 		reg = <0x0 0xfe190200 0x0 0x20>;
 	};
+
+	gmac0: ethernet@fe2a0000 {
+		compatible = "rockchip,rk3568-gmac", "snps,dwmac-4.20a";
+		reg = <0x0 0xfe2a0000 0x0 0x10000>;
+		interrupts = <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
+		interrupt-names = "macirq", "eth_wake_irq";
+		clocks = <&cru SCLK_GMAC0>, <&cru SCLK_GMAC0_RX_TX>,
+			 <&cru SCLK_GMAC0_RX_TX>, <&cru CLK_MAC0_REFOUT>,
+			 <&cru ACLK_GMAC0>, <&cru PCLK_GMAC0>,
+			 <&cru SCLK_GMAC0_RX_TX>, <&cru CLK_GMAC0_PTP_REF>,
+			 <&cru PCLK_XPCS>;
+		clock-names = "stmmaceth", "mac_clk_rx",
+			      "mac_clk_tx", "clk_mac_refout",
+			      "aclk_mac", "pclk_mac",
+			      "clk_mac_speed", "ptp_ref",
+			      "pclk_xpcs";
+		resets = <&cru SRST_A_GMAC0>;
+		reset-names = "stmmaceth";
+		rockchip,grf = <&grf>;
+		snps,axi-config = <&gmac0_stmmac_axi_setup>;
+		snps,mixed-burst;
+		snps,mtl-rx-config = <&gmac0_mtl_rx_setup>;
+		snps,mtl-tx-config = <&gmac0_mtl_tx_setup>;
+		snps,tso;
+		status = "disabled";
+
+		mdio0: mdio {
+			compatible = "snps,dwmac-mdio";
+			#address-cells = <0x1>;
+			#size-cells = <0x0>;
+		};
+
+		gmac0_stmmac_axi_setup: stmmac-axi-config {
+			snps,blen = <0 0 0 0 16 8 4>;
+			snps,rd_osr_lmt = <8>;
+			snps,wr_osr_lmt = <4>;
+		};
+
+		gmac0_mtl_rx_setup: rx-queues-config {
+			snps,rx-queues-to-use = <1>;
+			queue0 {};
+		};
+
+		gmac0_mtl_tx_setup: tx-queues-config {
+			snps,tx-queues-to-use = <1>;
+			queue0 {};
+		};
+	};
 };
 
 &cpu0_opp_table {
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2 2/2] arm64: dts: rockchip: rk3568-evb1-v10: add ethernet support
  2021-07-29  9:39 [PATCH v2 0/2] add ethernet support to rk3568 dts Michael Riesch
  2021-07-29  9:39 ` [PATCH v2 1/2] arm64: dts: rockchip: add gmac0 node to rk3568 Michael Riesch
@ 2021-07-29  9:39 ` Michael Riesch
  2021-07-29 13:19 ` [PATCH v2 0/2] add ethernet support to rk3568 dts Heiko Stuebner
  2 siblings, 0 replies; 4+ messages in thread
From: Michael Riesch @ 2021-07-29  9:39 UTC (permalink / raw)
  To: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
  Cc: Rob Herring, Heiko Stuebner, Liang Chen, Peter Geis,
	Michael Riesch, Simon Xue

Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
---
v2:
- sort properties alphabetically
- use phy-mode "rgmii-id" without delay properties
- rename phy nodes to "ethernet-phy"

 .../boot/dts/rockchip/rk3568-evb1-v10.dts     | 57 +++++++++++++++++++
 1 file changed, 57 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
index 69786557093d..65e536c78d2e 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
@@ -13,6 +13,11 @@
 	model = "Rockchip RK3568 EVB1 DDR4 V10 Board";
 	compatible = "rockchip,rk3568-evb1-v10", "rockchip,rk3568";
 
+	aliases {
+		ethernet0 = &gmac0;
+		ethernet1 = &gmac1;
+	};
+
 	chosen: chosen {
 		stdout-path = "serial2:1500000n8";
 	};
@@ -67,6 +72,58 @@
 	};
 };
 
+&gmac0 {
+	assigned-clocks = <&cru SCLK_GMAC0_RX_TX>, <&cru SCLK_GMAC0>;
+	assigned-clock-parents = <&cru SCLK_GMAC0_RGMII_SPEED>;
+	assigned-clock-rates = <0>, <125000000>;
+	clock_in_out = "output";
+	phy-handle = <&rgmii_phy0>;
+	phy-mode = "rgmii-id";
+	pinctrl-names = "default";
+	pinctrl-0 = <&gmac0_miim
+		     &gmac0_tx_bus2
+		     &gmac0_rx_bus2
+		     &gmac0_rgmii_clk
+		     &gmac0_rgmii_bus>;
+	status = "okay";
+};
+
+&gmac1 {
+	assigned-clocks = <&cru SCLK_GMAC1_RX_TX>, <&cru SCLK_GMAC1>;
+	assigned-clock-parents = <&cru SCLK_GMAC1_RGMII_SPEED>;
+	assigned-clock-rates = <0>, <125000000>;
+	clock_in_out = "output";
+	phy-handle = <&rgmii_phy1>;
+	phy-mode = "rgmii-id";
+	pinctrl-names = "default";
+	pinctrl-0 = <&gmac1m1_miim
+		     &gmac1m1_tx_bus2
+		     &gmac1m1_rx_bus2
+		     &gmac1m1_rgmii_clk
+		     &gmac1m1_rgmii_bus>;
+	status = "okay";
+};
+
+&mdio0 {
+	rgmii_phy0: ethernet-phy@0 {
+		compatible = "ethernet-phy-ieee802.3-c22";
+		reg = <0x0>;
+		reset-assert-us = <20000>;
+		reset-deassert-us = <100000>;
+		reset-gpios = <&gpio2 RK_PD3 GPIO_ACTIVE_LOW>;
+	};
+};
+
+&mdio1 {
+	rgmii_phy1: ethernet-phy@0 {
+		compatible = "ethernet-phy-ieee802.3-c22";
+		reg = <0x0>;
+		reset-assert-us = <20000>;
+		reset-deassert-us = <100000>;
+		reset-gpios = <&gpio2 RK_PD1 GPIO_ACTIVE_LOW>;
+	};
+};
+
 &sdhci {
 	bus-width = <8>;
 	max-frequency = <200000000>;
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 0/2] add ethernet support to rk3568 dts
  2021-07-29  9:39 [PATCH v2 0/2] add ethernet support to rk3568 dts Michael Riesch
  2021-07-29  9:39 ` [PATCH v2 1/2] arm64: dts: rockchip: add gmac0 node to rk3568 Michael Riesch
  2021-07-29  9:39 ` [PATCH v2 2/2] arm64: dts: rockchip: rk3568-evb1-v10: add ethernet support Michael Riesch
@ 2021-07-29 13:19 ` Heiko Stuebner
  2 siblings, 0 replies; 4+ messages in thread
From: Heiko Stuebner @ 2021-07-29 13:19 UTC (permalink / raw)
  To: linux-rockchip, devicetree, linux-kernel, linux-arm-kernel,
	Michael Riesch
  Cc: Heiko Stuebner, Simon Xue, Rob Herring, Peter Geis, Liang Chen

On Thu, 29 Jul 2021 11:39:11 +0200, Michael Riesch wrote:
> these patches should be orthogonal to the ongoing work of Peter Geis
> that aims to introduce the GMAC1 node to the common RK356x dts.
> The GMAC0 node, which is exclusive to the RK3568, and the Ethernet
> phy nodes in the RK3568 EVB1 are introduced by this series.
> 
> v2:
> - sort properties alphabetically
> - use phy-mode "rgmii-id" without delay properties
> - rename phy nodes to "ethernet-phy"
> 
> [...]

Applied, thanks!

[1/2] arm64: dts: rockchip: add gmac0 node to rk3568
      commit: 2ff79e4cec9850de4df59e3902197141de7ba9ea
[2/2] arm64: dts: rockchip: rk3568-evb1-v10: add ethernet support
      commit: f96f01eb249165631456e1d81aed0e2f3d4e2cea

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-07-29 13:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-29  9:39 [PATCH v2 0/2] add ethernet support to rk3568 dts Michael Riesch
2021-07-29  9:39 ` [PATCH v2 1/2] arm64: dts: rockchip: add gmac0 node to rk3568 Michael Riesch
2021-07-29  9:39 ` [PATCH v2 2/2] arm64: dts: rockchip: rk3568-evb1-v10: add ethernet support Michael Riesch
2021-07-29 13:19 ` [PATCH v2 0/2] add ethernet support to rk3568 dts Heiko Stuebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).