linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] cx20442: tty_ldisc_ops::write_wakeup is optional
@ 2021-07-22 11:51 Jiri Slaby
  2021-07-22 11:51 ` [PATCH 2/2] v253_init: eliminate pointer to string Jiri Slaby
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Jiri Slaby @ 2021-07-22 11:51 UTC (permalink / raw)
  To: gregkh
  Cc: linux-serial, linux-kernel, Jiri Slaby, Liam Girdwood,
	Mark Brown, Jaroslav Kysela, Takashi Iwai, alsa-devel

TTY layer does nothing if tty_ldisc_ops::write_wakeup is NULL, so there
is no need to implement an empty one in cx20442. Drop it.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org
---
 sound/soc/codecs/cx20442.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/sound/soc/codecs/cx20442.c b/sound/soc/codecs/cx20442.c
index ec8d6e74b467..65c6b92d7b5f 100644
--- a/sound/soc/codecs/cx20442.c
+++ b/sound/soc/codecs/cx20442.c
@@ -279,11 +279,6 @@ static void v253_receive(struct tty_struct *tty, const unsigned char *cp,
 	}
 }
 
-/* Line discipline .write_wakeup() */
-static void v253_wakeup(struct tty_struct *tty)
-{
-}
-
 struct tty_ldisc_ops v253_ops = {
 	.name = "cx20442",
 	.owner = THIS_MODULE,
@@ -291,7 +286,6 @@ struct tty_ldisc_ops v253_ops = {
 	.close = v253_close,
 	.hangup = v253_hangup,
 	.receive_buf = v253_receive,
-	.write_wakeup = v253_wakeup,
 };
 EXPORT_SYMBOL_GPL(v253_ops);
 
-- 
2.32.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2] v253_init: eliminate pointer to string
  2021-07-22 11:51 [PATCH 1/2] cx20442: tty_ldisc_ops::write_wakeup is optional Jiri Slaby
@ 2021-07-22 11:51 ` Jiri Slaby
  2021-07-22 11:54 ` [PATCH 1/2] cx20442: tty_ldisc_ops::write_wakeup is optional Mark Brown
  2021-07-29 16:39 ` Mark Brown
  2 siblings, 0 replies; 4+ messages in thread
From: Jiri Slaby @ 2021-07-22 11:51 UTC (permalink / raw)
  To: gregkh
  Cc: linux-serial, linux-kernel, Jiri Slaby, Liam Girdwood,
	Mark Brown, Jaroslav Kysela, Takashi Iwai, alsa-devel

There is no need to have an extra pointer to a string (v253_init).
Convert it to an array.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org
---
 sound/soc/codecs/cx20442.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/cx20442.c b/sound/soc/codecs/cx20442.c
index 65c6b92d7b5f..13258f3ca9aa 100644
--- a/sound/soc/codecs/cx20442.c
+++ b/sound/soc/codecs/cx20442.c
@@ -206,7 +206,7 @@ static int cx20442_write(struct snd_soc_component *component, unsigned int reg,
  */
 
 /* Modem init: echo off, digital speaker off, quiet off, voice mode */
-static const char *v253_init = "ate0m0q0+fclass=8\r";
+static const char v253_init[] = "ate0m0q0+fclass=8\r";
 
 /* Line discipline .open() */
 static int v253_open(struct tty_struct *tty)
-- 
2.32.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] cx20442: tty_ldisc_ops::write_wakeup is optional
  2021-07-22 11:51 [PATCH 1/2] cx20442: tty_ldisc_ops::write_wakeup is optional Jiri Slaby
  2021-07-22 11:51 ` [PATCH 2/2] v253_init: eliminate pointer to string Jiri Slaby
@ 2021-07-22 11:54 ` Mark Brown
  2021-07-29 16:39 ` Mark Brown
  2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2021-07-22 11:54 UTC (permalink / raw)
  To: Jiri Slaby
  Cc: gregkh, linux-serial, linux-kernel, Liam Girdwood,
	Jaroslav Kysela, Takashi Iwai, alsa-devel

[-- Attachment #1: Type: text/plain, Size: 525 bytes --]

On Thu, Jul 22, 2021 at 01:51:40PM +0200, Jiri Slaby wrote:
> TTY layer does nothing if tty_ldisc_ops::write_wakeup is NULL, so there
> is no need to implement an empty one in cx20442. Drop it.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] cx20442: tty_ldisc_ops::write_wakeup is optional
  2021-07-22 11:51 [PATCH 1/2] cx20442: tty_ldisc_ops::write_wakeup is optional Jiri Slaby
  2021-07-22 11:51 ` [PATCH 2/2] v253_init: eliminate pointer to string Jiri Slaby
  2021-07-22 11:54 ` [PATCH 1/2] cx20442: tty_ldisc_ops::write_wakeup is optional Mark Brown
@ 2021-07-29 16:39 ` Mark Brown
  2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2021-07-29 16:39 UTC (permalink / raw)
  To: gregkh, Jiri Slaby
  Cc: Mark Brown, linux-serial, Liam Girdwood, linux-kernel,
	Takashi Iwai, alsa-devel, Jaroslav Kysela

On Thu, 22 Jul 2021 13:51:40 +0200, Jiri Slaby wrote:
> TTY layer does nothing if tty_ldisc_ops::write_wakeup is NULL, so there
> is no need to implement an empty one in cx20442. Drop it.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] cx20442: tty_ldisc_ops::write_wakeup is optional
      commit: d7a3a6801913a4b57a7e525c4906d348213acfb0
[2/2] v253_init: eliminate pointer to string
      commit: dfe1114638d1888916fd9ceb50314e19f632dfad

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-07-29 16:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-22 11:51 [PATCH 1/2] cx20442: tty_ldisc_ops::write_wakeup is optional Jiri Slaby
2021-07-22 11:51 ` [PATCH 2/2] v253_init: eliminate pointer to string Jiri Slaby
2021-07-22 11:54 ` [PATCH 1/2] cx20442: tty_ldisc_ops::write_wakeup is optional Mark Brown
2021-07-29 16:39 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).