linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] bcm63xx_enet: delete a redundant assignment
@ 2021-07-29  4:03 Tang Bin
  2021-07-29  4:15 ` Florian Fainelli
  2021-07-29 21:20 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Tang Bin @ 2021-07-29  4:03 UTC (permalink / raw)
  To: davem, kuba, f.fainelli, bcm-kernel-feedback-list
  Cc: netdev, linux-arm-kernel, linux-kernel, Tang Bin, Zhang Shengju

In the function bcm_enetsw_probe(), 'ret' will be assigned by
bcm_enet_change_mtu(), so 'ret = 0' make no sense.

Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
Changes from v1
 - fix up the subject
---
 drivers/net/ethernet/broadcom/bcm63xx_enet.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
index 916824cca..509e10013 100644
--- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
+++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
@@ -2646,7 +2646,6 @@ static int bcm_enetsw_probe(struct platform_device *pdev)
 	if (!res_mem || irq_rx < 0)
 		return -ENODEV;
 
-	ret = 0;
 	dev = alloc_etherdev(sizeof(*priv));
 	if (!dev)
 		return -ENOMEM;
-- 
2.20.1.windows.1




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] bcm63xx_enet: delete a redundant assignment
  2021-07-29  4:03 [PATCH v2] bcm63xx_enet: delete a redundant assignment Tang Bin
@ 2021-07-29  4:15 ` Florian Fainelli
  2021-07-29 21:20 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2021-07-29  4:15 UTC (permalink / raw)
  To: Tang Bin, davem, kuba, bcm-kernel-feedback-list
  Cc: netdev, linux-arm-kernel, linux-kernel, Zhang Shengju



On 7/28/2021 9:03 PM, Tang Bin wrote:
> In the function bcm_enetsw_probe(), 'ret' will be assigned by
> bcm_enet_change_mtu(), so 'ret = 0' make no sense.
> 
> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] bcm63xx_enet: delete a redundant assignment
  2021-07-29  4:03 [PATCH v2] bcm63xx_enet: delete a redundant assignment Tang Bin
  2021-07-29  4:15 ` Florian Fainelli
@ 2021-07-29 21:20 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-07-29 21:20 UTC (permalink / raw)
  To: Tang Bin
  Cc: davem, kuba, f.fainelli, bcm-kernel-feedback-list, netdev,
	linux-arm-kernel, linux-kernel, zhangshengju

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Thu, 29 Jul 2021 12:03:00 +0800 you wrote:
> In the function bcm_enetsw_probe(), 'ret' will be assigned by
> bcm_enet_change_mtu(), so 'ret = 0' make no sense.
> 
> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
> Changes from v1
>  - fix up the subject
> 
> [...]

Here is the summary with links:
  - [v2] bcm63xx_enet: delete a redundant assignment
    https://git.kernel.org/netdev/net-next/c/3e12361b6d23

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-29 21:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-29  4:03 [PATCH v2] bcm63xx_enet: delete a redundant assignment Tang Bin
2021-07-29  4:15 ` Florian Fainelli
2021-07-29 21:20 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).