linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] xtensa: ISS: Fix warning comparing pointer to 0
@ 2021-07-30 10:29 Jiapeng Chong
  2021-08-10 23:21 ` Max Filippov
  0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-07-30 10:29 UTC (permalink / raw)
  To: chris; +Cc: jcmvbkbc, linux-xtensa, linux-kernel, Jiapeng Chong

Fix the following coccicheck warning:

./arch/xtensa/platforms/iss/console.c:204:10-11: WARNING comparing
pointer to 0.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 arch/xtensa/platforms/iss/console.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/xtensa/platforms/iss/console.c b/arch/xtensa/platforms/iss/console.c
index 81f9889..92d4624 100644
--- a/arch/xtensa/platforms/iss/console.c
+++ b/arch/xtensa/platforms/iss/console.c
@@ -201,7 +201,7 @@ static void iss_console_write(struct console *co, const char *s, unsigned count)
 {
 	int len = strlen(s);
 
-	if (s != 0 && *s != 0)
+	if (s && *s != 0)
 		simc_write(1, s, count < len ? count : len);
 }
 
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] xtensa: ISS: Fix warning comparing pointer to 0
  2021-07-30 10:29 [PATCH] xtensa: ISS: Fix warning comparing pointer to 0 Jiapeng Chong
@ 2021-08-10 23:21 ` Max Filippov
  0 siblings, 0 replies; 2+ messages in thread
From: Max Filippov @ 2021-08-10 23:21 UTC (permalink / raw)
  To: Jiapeng Chong
  Cc: Chris Zankel, open list:TENSILICA XTENSA PORT (xtensa), LKML

Hi Jiapeng,

On Fri, Jul 30, 2021 at 3:30 AM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> Fix the following coccicheck warning:
>
> ./arch/xtensa/platforms/iss/console.c:204:10-11: WARNING comparing
> pointer to 0.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  arch/xtensa/platforms/iss/console.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/xtensa/platforms/iss/console.c b/arch/xtensa/platforms/iss/console.c
> index 81f9889..92d4624 100644
> --- a/arch/xtensa/platforms/iss/console.c
> +++ b/arch/xtensa/platforms/iss/console.c
> @@ -201,7 +201,7 @@ static void iss_console_write(struct console *co, const char *s, unsigned count)
>  {
>         int len = strlen(s);

Here's a bigger issue in this function: s is used in strlen before it
is checked for NULL.
I've posted another patch that fixes it.

> -       if (s != 0 && *s != 0)
> +       if (s && *s != 0)
>                 simc_write(1, s, count < len ? count : len);
>  }
>
> --
> 1.8.3.1
>

-- 
Thanks.
-- Max

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-10 23:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-30 10:29 [PATCH] xtensa: ISS: Fix warning comparing pointer to 0 Jiapeng Chong
2021-08-10 23:21 ` Max Filippov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).