From: Randy Dunlap <rdunlap@infradead.org>
To: Robert Foss <robert.foss@linaro.org>,
a.hajda@samsung.com, narmstrong@baylibre.com,
Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
jernej.skrabec@siol.net, airlied@linux.ie, daniel@ffwll.ch,
cw00.choi@samsung.com, m.purski@samsung.com,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Masahiro Yamada <masahiroy@kernel.org>
Cc: kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v3] drm/bridge/sii8620: fix dependency on extcon
Date: Mon, 19 Apr 2021 10:10:46 -0700 [thread overview]
Message-ID: <1627725d-1c7e-109f-f995-e761bb022ccc@infradead.org> (raw)
In-Reply-To: <20210419090124.153560-1-robert.foss@linaro.org>
On 4/19/21 2:01 AM, Robert Foss wrote:
> The DRM_SIL_SII8620 kconfig has a weak `imply` dependency
> on EXTCON, which causes issues when sii8620 is built
> as a builtin and EXTCON is built as a module.
>
> The symptoms are 'undefined reference' errors caused
> by the symbols in EXTCON not being available
> to the sii8620 driver.
>
> Fixes: 688838442147 ("drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL")
> Signed-off-by: Robert Foss <robert.foss@linaro.org>
> Reported-by: kernel test robot <lkp@intel.com>
> ---
>
> LKP reported issue:
> https://lore.kernel.org/lkml/202104040604.SSTe2Cxf-lkp@intel.com/
>
>
> Changes since v1:
> - Fix typo on comment
>
> Changes since v2:
> - Randy: Changed from `depends` to `select`
I don't know why my name is on that. I didn't
suggest any change -- I just reported that v2
had a problem.
>
>
> drivers/gpu/drm/bridge/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 22a467abd3e9..70402da5cc70 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -169,7 +169,7 @@ config DRM_SIL_SII8620
> tristate "Silicon Image SII8620 HDMI/MHL bridge"
> depends on OF
> select DRM_KMS_HELPER
> - imply EXTCON
> + select EXTCON
> depends on RC_CORE || !RC_CORE
> help
> Silicon Image SII8620 HDMI/MHL bridge chip driver.
Thanks. Works For Me.
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
--
~Randy
next prev parent reply other threads:[~2021-04-19 17:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 9:01 [PATCH v3] drm/bridge/sii8620: fix dependency on extcon Robert Foss
2021-04-19 17:10 ` Randy Dunlap [this message]
2021-04-19 17:54 ` Randy Dunlap
2021-05-15 5:34 ` Randy Dunlap
2021-05-15 12:09 ` Robert Foss
2021-05-15 15:46 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1627725d-1c7e-109f-f995-e761bb022ccc@infradead.org \
--to=rdunlap@infradead.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=cw00.choi@samsung.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=m.purski@samsung.com \
--cc=masahiroy@kernel.org \
--cc=narmstrong@baylibre.com \
--cc=robert.foss@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).