* [PATCH] posix-timers: remove redundant initialization of variable ret
@ 2021-07-21 12:01 Colin King
2021-08-10 15:07 ` [tip: timers/core] posix-timers: Remove " tip-bot2 for Colin Ian King
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2021-07-21 12:01 UTC (permalink / raw)
To: Thomas Gleixner, linux-kernel; +Cc: kernel-janitors
From: Colin Ian King <colin.king@canonical.com>
The variable ret is being initialized with a value that is never
read, it is being updated later on. The assignment is redundant and
can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
kernel/time/posix-timers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/time/posix-timers.c b/kernel/time/posix-timers.c
index dd5697d7347b..3913222e7bcf 100644
--- a/kernel/time/posix-timers.c
+++ b/kernel/time/posix-timers.c
@@ -336,7 +336,7 @@ void posixtimer_rearm(struct kernel_siginfo *info)
int posix_timer_event(struct k_itimer *timr, int si_private)
{
enum pid_type type;
- int ret = -1;
+ int ret;
/*
* FIXME: if ->sigq is queued we can race with
* dequeue_signal()->posixtimer_rearm().
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip: timers/core] posix-timers: Remove redundant initialization of variable ret
2021-07-21 12:01 [PATCH] posix-timers: remove redundant initialization of variable ret Colin King
@ 2021-08-10 15:07 ` tip-bot2 for Colin Ian King
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Colin Ian King @ 2021-08-10 15:07 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Colin Ian King, Thomas Gleixner, x86, linux-kernel
The following commit has been merged into the timers/core branch of tip:
Commit-ID: 1dae37c7e41d9a75a615ba7b0480acc2e04094d4
Gitweb: https://git.kernel.org/tip/1dae37c7e41d9a75a615ba7b0480acc2e04094d4
Author: Colin Ian King <colin.king@canonical.com>
AuthorDate: Wed, 21 Jul 2021 13:01:47 +01:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Tue, 10 Aug 2021 17:02:11 +02:00
posix-timers: Remove redundant initialization of variable ret
The variable ret is being initialized with a value that is never read, it
is being updated later on. The assignment is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20210721120147.109570-1-colin.king@canonical.com
---
kernel/time/posix-timers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/time/posix-timers.c b/kernel/time/posix-timers.c
index dd5697d..3913222 100644
--- a/kernel/time/posix-timers.c
+++ b/kernel/time/posix-timers.c
@@ -336,7 +336,7 @@ void posixtimer_rearm(struct kernel_siginfo *info)
int posix_timer_event(struct k_itimer *timr, int si_private)
{
enum pid_type type;
- int ret = -1;
+ int ret;
/*
* FIXME: if ->sigq is queued we can race with
* dequeue_signal()->posixtimer_rearm().
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-10 15:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-21 12:01 [PATCH] posix-timers: remove redundant initialization of variable ret Colin King
2021-08-10 15:07 ` [tip: timers/core] posix-timers: Remove " tip-bot2 for Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).