[PATCH v2] genirq/timings: Fix error return code in irq_timings_test_irqs()

[PATCH v2] genirq/timings: Fix error return code in irq_timings_test_irqs()

[Zhen Lei]

Fix to return a negative error code from the error handling case instead
of 0, as done elsewhere in this function.

Fixes: f52da98d900e ("genirq/timings: Add selftest for irqs circular buffer")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 kernel/irq/timings.c | 2 ++
 1 file changed, 2 insertions(+)

v1 --> v2:
Replace -EFAULT with two more appropriate error codes.

diff --git a/kernel/irq/timings.c b/kernel/irq/timings.c
index d309d6fbf5bd..59affb3bfdfa 100644
--- a/kernel/irq/timings.c
+++ b/kernel/irq/timings.c
@@ -794,12 +794,14 @@ static int __init irq_timings_test_irqs(struct timings_intervals *ti)
 
 		__irq_timings_store(irq, irqs, ti->intervals[i]);
 		if (irqs->circ_timings[i & IRQ_TIMINGS_MASK] != index) {
+			ret = -EBADSLT;
 			pr_err("Failed to store in the circular buffer\n");
 			goto out;
 		}
 	}
 
 	if (irqs->count != ti->count) {
+		ret = -ERANGE;
 		pr_err("Count differs\n");
 		goto out;
 	}
-- 
2.25.1

[tip: irq/core] genirq/timings: Fix error return code in irq_timings_test_irqs()

[tip-bot2 for Zhen Lei]

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     290fdc4b7ef14e33d0e30058042b0e9bfd02b89b
Gitweb:        https://git.kernel.org/tip/290fdc4b7ef14e33d0e30058042b0e9bfd02b89b
Author:        Zhen Lei <thunder.leizhen@huawei.com>
AuthorDate:    Wed, 11 Aug 2021 17:33:32 +08:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Wed, 11 Aug 2021 14:33:35 +02:00

genirq/timings: Fix error return code in irq_timings_test_irqs()

Return a negative error code from the error handling case instead of 0, as
done elsewhere in this function.

Fixes: f52da98d900e ("genirq/timings: Add selftest for irqs circular buffer")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20210811093333.2376-1-thunder.leizhen@huawei.com

---
 kernel/irq/timings.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/kernel/irq/timings.c b/kernel/irq/timings.c
index d309d6f..59affb3 100644
--- a/kernel/irq/timings.c
+++ b/kernel/irq/timings.c
@@ -794,12 +794,14 @@ static int __init irq_timings_test_irqs(struct timings_intervals *ti)
 
 		__irq_timings_store(irq, irqs, ti->intervals[i]);
 		if (irqs->circ_timings[i & IRQ_TIMINGS_MASK] != index) {
+			ret = -EBADSLT;
 			pr_err("Failed to store in the circular buffer\n");
 			goto out;
 		}
 	}
 
 	if (irqs->count != ti->count) {
+		ret = -ERANGE;
 		pr_err("Count differs\n");
 		goto out;
 	}

Re: [PATCH v2] genirq/timings: Fix error return code in irq_timings_test_irqs()

[Daniel Lezcano]

On 11/08/2021 11:33, Zhen Lei wrote:
> Fix to return a negative error code from the error handling case instead
> of 0, as done elsewhere in this function.
> 
> Fixes: f52da98d900e ("genirq/timings: Add selftest for irqs circular buffer")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>

Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>

> ---
>  kernel/irq/timings.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> v1 --> v2:
> Replace -EFAULT with two more appropriate error codes.
> 
> diff --git a/kernel/irq/timings.c b/kernel/irq/timings.c
> index d309d6fbf5bd..59affb3bfdfa 100644
> --- a/kernel/irq/timings.c
> +++ b/kernel/irq/timings.c
> @@ -794,12 +794,14 @@ static int __init irq_timings_test_irqs(struct timings_intervals *ti)
>  
>  		__irq_timings_store(irq, irqs, ti->intervals[i]);
>  		if (irqs->circ_timings[i & IRQ_TIMINGS_MASK] != index) {
> +			ret = -EBADSLT;
>  			pr_err("Failed to store in the circular buffer\n");
>  			goto out;
>  		}
>  	}
>  
>  	if (irqs->count != ti->count) {
> +		ret = -ERANGE;
>  		pr_err("Count differs\n");
>  		goto out;
>  	}
> 


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog