From: David Mosberger <davidm@napali.hpl.hp.com>
To: Martin Josefsson <gandalf@wlug.westbo.se>
Cc: davidm@hpl.hp.com, linux-kernel@vger.kernel.org,
netdev@oss.sgi.com, davem@redhat.com
Subject: Re: status of ipchains in 2.6?
Date: Tue, 28 Oct 2003 16:16:04 -0800 [thread overview]
Message-ID: <16287.1732.427119.22477@napali.hpl.hp.com> (raw)
In-Reply-To: <1067365417.14002.18.camel@tux.rsn.bth.se>
Yes, Rusty mentioned the same patch yesterday. I tried it now and
ipchain masquerading seems to be working fine again.
--david
>>>>> On Tue, 28 Oct 2003 19:23:37 +0100, Martin Josefsson <gandalf@wlug.westbo.se> said:
Martin> Please try this patch that just got included in linus tree.
Martin> ChangeSet 1.1360, 2003/10/27 00:01:25-08:00, rusty@rustcorp.com.au
Martin> [NETFILTER]: Fix ipchains oops in NAT
Martin> We updated ip_nat_setup_info to set the initialized flag and call
Martin> place_in_hashes, but *didn't* change the call in ip_fw_compat_masq.c
Martin> which also calls place_in_hashes() itself (again!). Result: corrupt
Martin> list, and next thing which lands in the same hash bucket goes boom.
Martin> Thanks to Andy Polyakov for chasing this down.
Martin> # This patch includes the following deltas:
Martin> # ChangeSet 1.1359 -> 1.1360
Martin> # net/ipv4/netfilter/ip_fw_compat_masq.c 1.11 -> 1.12
Martin> #
Martin> ip_fw_compat_masq.c | 3 ---
Martin> 1 files changed, 3 deletions(-)
Martin> diff -Nru a/net/ipv4/netfilter/ip_fw_compat_masq.c b/net/ipv4/netfilter/ip_fw_compat_masq.c
Martin> --- a/net/ipv4/netfilter/ip_fw_compat_masq.c Mon Oct 27 12:07:33 2003
Martin> +++ b/net/ipv4/netfilter/ip_fw_compat_masq.c Mon Oct 27 12:07:33 2003
Martin> @@ -91,9 +91,6 @@
Martin> WRITE_UNLOCK(&ip_nat_lock);
Martin> return ret;
Martin> }
Martin> -
Martin> - place_in_hashes(ct, info);
Martin> - info->initialized = 1;
Martin> } else
Martin> DEBUGP("Masquerading already done on this conn.\n");
Martin> WRITE_UNLOCK(&ip_nat_lock);
Martin> --
Martin> /Martin
next prev parent reply other threads:[~2003-10-29 0:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-28 1:27 status of ipchains in 2.6? David Mosberger
2003-10-28 8:23 ` Holger Schurig
2003-10-28 8:28 ` Marc-Christian Petersen
2003-10-28 13:13 ` bill davidsen
2003-10-28 9:03 ` Éric Brunet
2003-10-28 9:50 ` David S. Miller
2003-10-28 11:10 ` Miquel van Smoorenburg
2003-10-28 11:33 ` Wichert Akkerman
2003-10-28 12:26 ` Sebastian Piecha
2003-10-28 13:09 ` bill davidsen
2003-10-28 17:56 ` David Mosberger
2003-10-28 17:57 ` David S. Miller
2003-10-28 19:25 ` David Mosberger
2003-10-28 18:23 ` Martin Josefsson
2003-10-29 0:16 ` David Mosberger [this message]
2003-10-31 8:52 ` Éric Brunet
[not found] <200310280127.h9S1RM5d002140@napali.hpl.hp.com.suse.lists.linux.kernel>
[not found] ` <20031028090304.GA19302@lps.ens.fr.suse.lists.linux.kernel>
2003-10-28 14:31 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16287.1732.427119.22477@napali.hpl.hp.com \
--to=davidm@napali.hpl.hp.com \
--cc=davem@redhat.com \
--cc=davidm@hpl.hp.com \
--cc=gandalf@wlug.westbo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).