* [PATCH v3 RESEND] x86/tools: fix objdump version check again
@ 2021-07-31 0:01 Randy Dunlap
2021-07-31 0:17 ` Masami Hiramatsu
2021-08-12 15:19 ` [tip: x86/urgent] x86/tools: Fix " tip-bot2 for Randy Dunlap
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2021-07-31 0:01 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Masami Hiramatsu, Thomas Gleixner, Ingo Molnar,
Ingo Molnar, Andrew Morton, H . Peter Anvin, x86,
Borislav Petkov
Skip (omit) any version string info that is parenthesized.
Warning: objdump version 15) is older than 2.19
Warning: Skipping posttest.
where 'objdump -v' says:
GNU objdump (GNU Binutils; SUSE Linux Enterprise 15) 2.35.1.20201123-7.18
Fixes: 8bee738bb1979 ("x86: Fix objdump version check in chkobjdump.awk for different formats.")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: x86@kernel.org
Cc: Borislav Petkov <bp@alien8.de>
---
v3: rebase & resend
correct Ingo's email address (not @elte.hu)
add x86@kernel.org email address
add BP's email address
arch/x86/tools/chkobjdump.awk | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20210715.orig/arch/x86/tools/chkobjdump.awk
+++ linux-next-20210715/arch/x86/tools/chkobjdump.awk
@@ -10,6 +10,7 @@ BEGIN {
/^GNU objdump/ {
verstr = ""
+ gsub(/\(.*\)/, "");
for (i = 3; i <= NF; i++)
if (match($(i), "^[0-9]")) {
verstr = $(i);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3 RESEND] x86/tools: fix objdump version check again
2021-07-31 0:01 [PATCH v3 RESEND] x86/tools: fix objdump version check again Randy Dunlap
@ 2021-07-31 0:17 ` Masami Hiramatsu
2021-08-12 15:19 ` [tip: x86/urgent] x86/tools: Fix " tip-bot2 for Randy Dunlap
1 sibling, 0 replies; 3+ messages in thread
From: Masami Hiramatsu @ 2021-07-31 0:17 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Masami Hiramatsu, Thomas Gleixner, Ingo Molnar,
Ingo Molnar, Andrew Morton, H . Peter Anvin, x86,
Borislav Petkov
On Fri, 30 Jul 2021 17:01:46 -0700
Randy Dunlap <rdunlap@infradead.org> wrote:
> Skip (omit) any version string info that is parenthesized.
>
> Warning: objdump version 15) is older than 2.19
> Warning: Skipping posttest.
>
> where 'objdump -v' says:
> GNU objdump (GNU Binutils; SUSE Linux Enterprise 15) 2.35.1.20201123-7.18
Looks good to me.
Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
Thank you,
>
> Fixes: 8bee738bb1979 ("x86: Fix objdump version check in chkobjdump.awk for different formats.")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Masami Hiramatsu <mhiramat@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: x86@kernel.org
> Cc: Borislav Petkov <bp@alien8.de>
> ---
> v3: rebase & resend
> correct Ingo's email address (not @elte.hu)
> add x86@kernel.org email address
> add BP's email address
>
> arch/x86/tools/chkobjdump.awk | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20210715.orig/arch/x86/tools/chkobjdump.awk
> +++ linux-next-20210715/arch/x86/tools/chkobjdump.awk
> @@ -10,6 +10,7 @@ BEGIN {
>
> /^GNU objdump/ {
> verstr = ""
> + gsub(/\(.*\)/, "");
> for (i = 3; i <= NF; i++)
> if (match($(i), "^[0-9]")) {
> verstr = $(i);
--
Masami Hiramatsu <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip: x86/urgent] x86/tools: Fix objdump version check again
2021-07-31 0:01 [PATCH v3 RESEND] x86/tools: fix objdump version check again Randy Dunlap
2021-07-31 0:17 ` Masami Hiramatsu
@ 2021-08-12 15:19 ` tip-bot2 for Randy Dunlap
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Randy Dunlap @ 2021-08-12 15:19 UTC (permalink / raw)
To: linux-tip-commits
Cc: Randy Dunlap, Thomas Gleixner, Masami Hiramatsu, x86, linux-kernel
The following commit has been merged into the x86/urgent branch of tip:
Commit-ID: 839ad22f755132838f406751439363c07272ad87
Gitweb: https://git.kernel.org/tip/839ad22f755132838f406751439363c07272ad87
Author: Randy Dunlap <rdunlap@infradead.org>
AuthorDate: Fri, 30 Jul 2021 17:01:46 -07:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Thu, 12 Aug 2021 17:17:25 +02:00
x86/tools: Fix objdump version check again
Skip (omit) any version string info that is parenthesized.
Warning: objdump version 15) is older than 2.19
Warning: Skipping posttest.
where 'objdump -v' says:
GNU objdump (GNU Binutils; SUSE Linux Enterprise 15) 2.35.1.20201123-7.18
Fixes: 8bee738bb1979 ("x86: Fix objdump version check in chkobjdump.awk for different formats.")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
Link: https://lore.kernel.org/r/20210731000146.2720-1-rdunlap@infradead.org
---
arch/x86/tools/chkobjdump.awk | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/tools/chkobjdump.awk b/arch/x86/tools/chkobjdump.awk
index fd1ab80..a4cf678 100644
--- a/arch/x86/tools/chkobjdump.awk
+++ b/arch/x86/tools/chkobjdump.awk
@@ -10,6 +10,7 @@ BEGIN {
/^GNU objdump/ {
verstr = ""
+ gsub(/\(.*\)/, "");
for (i = 3; i <= NF; i++)
if (match($(i), "^[0-9]")) {
verstr = $(i);
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-12 15:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-31 0:01 [PATCH v3 RESEND] x86/tools: fix objdump version check again Randy Dunlap
2021-07-31 0:17 ` Masami Hiramatsu
2021-08-12 15:19 ` [tip: x86/urgent] x86/tools: Fix " tip-bot2 for Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).