From: Will Deacon <will@kernel.org>
To: robin.murphy@arm.com, John Garry <john.garry@huawei.com>
Cc: catalin.marinas@arm.com, kernel-team@android.com,
Will Deacon <will@kernel.org>,
iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org, thunder.leizhen@huawei.com,
joro@8bytes.org, linuxarm@huawei.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/arm-smmu-v3: Stop pre-zeroing batch commands
Date: Fri, 13 Aug 2021 15:33:47 +0100 [thread overview]
Message-ID: <162886116698.2824022.16783624022186581694.b4-ty@kernel.org> (raw)
In-Reply-To: <1628696966-88386-1-git-send-email-john.garry@huawei.com>
On Wed, 11 Aug 2021 23:49:26 +0800, John Garry wrote:
> Pre-zeroing the batched commands structure is inefficient, as individual
> commands are zeroed later in arm_smmu_cmdq_build_cmd(). The size is quite
> large and commonly most commands won't even be used:
>
> struct arm_smmu_cmdq_batch cmds = {};
> 345c: 52800001 mov w1, #0x0 // #0
> 3460: d2808102 mov x2, #0x408 // #1032
> 3464: 910143a0 add x0, x29, #0x50
> 3468: 94000000 bl 0 <memset>
>
> [...]
Applied to will (for-joerg/arm-smmu/updates), thanks!
[1/1] iommu/arm-smmu-v3: Stop pre-zeroing batch commands
https://git.kernel.org/will/c/fac956710ab0
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
prev parent reply other threads:[~2021-08-13 14:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 15:49 [PATCH] iommu/arm-smmu-v3: Stop pre-zeroing batch commands John Garry
2021-08-13 14:33 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162886116698.2824022.16783624022186581694.b4-ty@kernel.org \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=john.garry@huawei.com \
--cc=joro@8bytes.org \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=robin.murphy@arm.com \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).