From: Rob Herring <robh@kernel.org>
To: amirmizi6@gmail.com
Cc: oshri.alkoby@nuvoton.com, tmaimon77@gmail.com, peterhuewe@gmx.de,
jarkko.sakkinen@linux.intel.com, kgoldman@us.ibm.com,
oshrialkoby85@gmail.com, jgg@ziepe.ca, shmulik.hager@nuvoton.com,
robh+dt@kernel.org, gregkh@linuxfoundation.org,
mark.rutland@arm.com, benoit.houyere@st.com,
amir.mizinski@nuvoton.com, oren.tanami@nuvoton.com,
joel@jms.id.au, devicetree@vger.kernel.org, gcwilson@us.ibm.com,
alexander.steffen@infineon.com, Dan.Morav@nuvoton.com,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
Eyal.Cohen@nuvoton.com, eajames@linux.ibm.com, arnd@arndb.de
Subject: Re: [PATCH v13 7/7] tpm: Add YAML schema for TPM TIS I2C options
Date: Thu, 26 Aug 2021 08:26:01 -0500 [thread overview]
Message-ID: <1629984361.421167.1033389.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20210826111908.117278-8-amirmizi6@gmail.com>
On Thu, 26 Aug 2021 14:19:08 +0300, amirmizi6@gmail.com wrote:
> From: Amir Mizinski <amirmizi6@gmail.com>
>
> Added a YAML schema to support tpm tis i2c related dt-bindings for the I2c
> PTP based physical layer.
>
> This patch adds the documentation for corresponding device tree bindings of
> I2C based Physical TPM.
> Refer to the 'I2C Interface Definition' section in
> 'TCG PC Client PlatformTPMProfile(PTP) Specification' publication
> for specification.
>
> Signed-off-by: Amir Mizinski <amirmizi6@gmail.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> .../bindings/security/tpm/tpm-tis-i2c.yaml | 50 ++++++++++++++++++++++
> 1 file changed, 50 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.yaml: 'additionalProperties' is a required property
hint: A schema without a "$ref" to another schema must define all properties and use "additionalProperties"
from schema $id: http://devicetree.org/meta-schemas/base.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.yaml: ignoring, error in schema:
warning: no schema found in file: ./Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.yaml
Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.example.dt.yaml:0:0: /example-0/i2c/tpm@2e: failed to match any schema with compatible: ['nuvoton,npct75x', 'tcg,tpm-tis-i2c']
Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.example.dt.yaml:0:0: /example-0/i2c/tpm@2e: failed to match any schema with compatible: ['nuvoton,npct75x', 'tcg,tpm-tis-i2c']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1521079
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2021-08-26 13:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 11:19 [PATCH v13 0/7] Add tpm i2c ptp driver amirmizi6
2021-08-26 11:19 ` [PATCH v13 1/7] tpm: Make read{16, 32}() and write32() in tpm_tis_phy_ops optional amirmizi6
2021-08-26 15:57 ` Jarkko Sakkinen
2021-08-26 11:19 ` [PATCH v13 2/7] tpm: tpm_tis: Fix expected bit handling and send all bytes in one shot without last byte in exception amirmizi6
2021-08-26 15:59 ` Jarkko Sakkinen
2021-08-26 11:19 ` [PATCH v13 3/7] tpm: tpm_tis: Rewrite "tpm_tis_req_canceled()" amirmizi6
2021-08-26 16:01 ` Jarkko Sakkinen
2021-08-26 11:19 ` [PATCH v13 4/7] tpm: Handle an exception for TPM Firmware Update mode amirmizi6
2021-08-26 16:02 ` Jarkko Sakkinen
2021-08-26 11:19 ` [PATCH v13 5/7] tpm: tpm_tis: verify TPM_STS register is valid after locality request amirmizi6
2021-08-26 16:03 ` Jarkko Sakkinen
2021-08-26 11:19 ` [PATCH v13 6/7] tpm: tpm_tis: add tpm_tis_i2c driver amirmizi6
2021-08-26 16:04 ` Jarkko Sakkinen
2021-08-26 11:19 ` [PATCH v13 7/7] tpm: Add YAML schema for TPM TIS I2C options amirmizi6
2021-08-26 13:26 ` Rob Herring [this message]
2021-08-26 16:05 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1629984361.421167.1033389.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=Dan.Morav@nuvoton.com \
--cc=Eyal.Cohen@nuvoton.com \
--cc=alexander.steffen@infineon.com \
--cc=amir.mizinski@nuvoton.com \
--cc=amirmizi6@gmail.com \
--cc=arnd@arndb.de \
--cc=benoit.houyere@st.com \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=gcwilson@us.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=joel@jms.id.au \
--cc=kgoldman@us.ibm.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=oren.tanami@nuvoton.com \
--cc=oshri.alkoby@nuvoton.com \
--cc=oshrialkoby85@gmail.com \
--cc=peterhuewe@gmx.de \
--cc=robh+dt@kernel.org \
--cc=shmulik.hager@nuvoton.com \
--cc=tmaimon77@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).