linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] ethtool: Fix an error code in cxgb2.c
@ 2021-09-03  6:42 Yang Li
  2021-09-04 10:00 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2021-09-03  6:42 UTC (permalink / raw)
  To: davem; +Cc: kuba, netdev, linux-kernel, Yang Li

When adapter->registered_device_map is NULL, the value of err is
uncertain, we set err to -EINVAL to avoid ambiguity.

Clean up smatch warning:
drivers/net/ethernet/chelsio/cxgb/cxgb2.c:1114 init_one() warn: missing
error code 'err'

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/net/ethernet/chelsio/cxgb/cxgb2.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/chelsio/cxgb/cxgb2.c b/drivers/net/ethernet/chelsio/cxgb/cxgb2.c
index 73c0161..d246eee 100644
--- a/drivers/net/ethernet/chelsio/cxgb/cxgb2.c
+++ b/drivers/net/ethernet/chelsio/cxgb/cxgb2.c
@@ -1111,6 +1111,7 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 	if (!adapter->registered_device_map) {
 		pr_err("%s: could not register any net devices\n",
 		       pci_name(pdev));
+		err = -EINVAL;
 		goto out_release_adapter_res;
 	}
 
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] ethtool: Fix an error code in cxgb2.c
  2021-09-03  6:42 [PATCH -next] ethtool: Fix an error code in cxgb2.c Yang Li
@ 2021-09-04 10:00 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-09-04 10:00 UTC (permalink / raw)
  To: Yang Li; +Cc: davem, kuba, netdev, linux-kernel

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Fri,  3 Sep 2021 14:42:33 +0800 you wrote:
> When adapter->registered_device_map is NULL, the value of err is
> uncertain, we set err to -EINVAL to avoid ambiguity.
> 
> Clean up smatch warning:
> drivers/net/ethernet/chelsio/cxgb/cxgb2.c:1114 init_one() warn: missing
> error code 'err'
> 
> [...]

Here is the summary with links:
  - [-next] ethtool: Fix an error code in cxgb2.c
    https://git.kernel.org/netdev/net/c/7db8263a1215

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-04 10:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-03  6:42 [PATCH -next] ethtool: Fix an error code in cxgb2.c Yang Li
2021-09-04 10:00 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).