linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Claudiu.Beznea@microchip.com,
	Ryan Chen <ryan_chen@aspeedtech.com>,
	andrew@aj.id.au, joel@jms.id.au, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org, mturquette@baylibre.com
Subject: RE: [PATCHv2] clk:aspeed:Fix AST2600 hpll calculate formula
Date: Tue, 14 Sep 2021 18:17:29 -0700	[thread overview]
Message-ID: <163166864956.763609.8140689140101809508@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <HK0PR06MB33806C10EB8B3F87FE144F8DF2D99@HK0PR06MB3380.apcprd06.prod.outlook.com>

Quoting Ryan Chen (2021-09-12 22:31:46)
> > > +               if (hwstrap & BIT(10))
> > > +                       m = 0x5F;
> > > +               else {
> > > +                       if (hwstrap & BIT(8))
> > 
> > You may write it directly:
> >                 else if (hwstrap & BIT(8))
> > 
> Hello,
>         Like I commit message M = SCU500[10] ? 0x5F : SCU500[8] ? 0xBF : SCU200[12:0]
>         it need keep from register read, if BIT(8)/BIT(10) not 1.
>         

I don't get it. The review comment was that the else { if (...) can be
collapsed into an else if (..) What does commit message have to do with
it?

  reply	other threads:[~2021-09-15  1:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-08  9:18 [PATCHv2] clk:aspeed:Fix AST2600 hpll calculate formula Ryan Chen
2021-09-13  5:26 ` Claudiu.Beznea
2021-09-13  5:31   ` Ryan Chen
2021-09-15  1:17     ` Stephen Boyd [this message]
2021-09-15  2:52       ` Ryan Chen
2021-09-15  3:07         ` Joel Stanley
2021-09-15  3:11           ` Ryan Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=163166864956.763609.8140689140101809508@swboyd.mtv.corp.google.com \
    --to=sboyd@kernel.org \
    --cc=Claudiu.Beznea@microchip.com \
    --cc=andrew@aj.id.au \
    --cc=joel@jms.id.au \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=ryan_chen@aspeedtech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).