From: Jiasheng Jiang <jiasheng@iscas.ac.cn>
To: pshelar@ovn.org, davem@davemloft.net, kuba@kernel.org
Cc: netdev@vger.kernel.org, dev@openvswitch.org,
linux-kernel@vger.kernel.org,
Jiasheng Jiang <jiasheng@iscas.ac.cn>
Subject: [PATCH] openvswitch: Fix condition check by using nla_ok()
Date: Thu, 16 Sep 2021 01:48:36 +0000 [thread overview]
Message-ID: <1631756916-3759083-1-git-send-email-jiasheng@iscas.ac.cn> (raw)
Just using 'rem > 0' might be unsafe, so it's better
to use the nla_ok() instead.
Because we can see from the nla_next() that
'*remaining' might be smaller than 'totlen'. And nla_ok()
will avoid it happening.
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
net/openvswitch/actions.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c
index 116e38a..8209ab1 100644
--- a/net/openvswitch/actions.c
+++ b/net/openvswitch/actions.c
@@ -915,7 +915,7 @@ static int output_userspace(struct datapath *dp, struct sk_buff *skb,
upcall.cmd = OVS_PACKET_CMD_ACTION;
upcall.mru = OVS_CB(skb)->mru;
- for (a = nla_data(attr), rem = nla_len(attr); rem > 0;
+ for (a = nla_data(attr), rem = nla_len(attr); nla_ok(a, rem);
a = nla_next(a, &rem)) {
switch (nla_type(a)) {
case OVS_USERSPACE_ATTR_USERDATA:
--
2.7.4
next reply other threads:[~2021-09-16 1:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 1:48 Jiasheng Jiang [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-09-16 1:43 [PATCH] openvswitch: Fix condition check by using nla_ok() Jiasheng Jiang
2021-09-16 14:36 ` Jakub Kicinski
2021-09-16 14:38 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1631756916-3759083-1-git-send-email-jiasheng@iscas.ac.cn \
--to=jiasheng@iscas.ac.cn \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).