From: Luca Weiss <luca@z3ntu.xyz>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Pascal PAILLET-LME <p.paillet@st.com>, Coly Li <colyli@suse.de>,
Lee Jones <lee.jones@linaro.org>,
Xiaotong Lu <xiaotong.lu@spreadtrum.com>,
Brian Masney <masneyb@onstation.org>,
Rob Herring <robh@kernel.org>,
Baolin Wang <baolin.wang@linaro.org>,
David Brown <david.brown@linaro.org>,
"open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@vger.kernel.org>,
"open list:INPUT KEYBOARD, MOUSE, JOYSTICK ,
TOUCHSCREEN..." <linux-input@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] Input: add a driver for GPIO controllable vibrators
Date: Tue, 16 Apr 2019 18:02:15 +0200 [thread overview]
Message-ID: <1633425.a675zxgQUS@g550jk> (raw)
In-Reply-To: <155509103299.20095.15957232326393337000@swboyd.mtv.corp.google.com>
On Freitag, 12. April 2019 19:43:52 CEST Stephen Boyd wrote:
> Quoting Luca Weiss (2019-04-12 08:06:24)
>
> > diff --git a/drivers/input/misc/gpio-vibra.c
> > b/drivers/input/misc/gpio-vibra.c new file mode 100644
> > index 000000000000..3fd2dfd4f670
> > --- /dev/null
> > +++ b/drivers/input/misc/gpio-vibra.c
> > @@ -0,0 +1,209 @@
> > +
> > +static int gpio_vibrator_probe(struct platform_device *pdev)
> > +{
>
> [...]
>
> > + vibrator->input->id.bustype = BUS_HOST;
> > + vibrator->input->close = gpio_vibrator_close;
> > +
> > + input_set_drvdata(vibrator->input, vibrator);
> > + input_set_capability(vibrator->input, EV_FF, FF_RUMBLE);
> > +
> > + err = input_ff_create_memless(vibrator->input, NULL,
> > + gpio_vibrator_play_effect);
> > + if (err) {
> > + dev_err(&pdev->dev, "Couldn't create FF dev: %d", err);
> > + return err;
> > + }
> > +
> > + err = input_register_device(vibrator->input);
> > + if (err) {
> > + dev_err(&pdev->dev, "Couldn't register input dev: %d",
> > err);
> All the printks in this file need a newline.
Fixed.
> > + return err;
> > + }
> > +
> > + platform_set_drvdata(pdev, vibrator);
> > +
> > + return 0;
> > +}
> > +
> > +
> > +#ifdef CONFIG_OF
> > +static const struct of_device_id gpio_vibra_dt_match_table[] = {
> > + { .compatible = "gpio-vibrator" },
> > + {},
>
> Nitpick: Drop the comma on the sentinel so nothing can go after it
> without causing a compilation error.
Changed as well.
> > +};
> > +MODULE_DEVICE_TABLE(of, gpio_vibra_dt_match_table);
> > +#endif
> > +
Thanks for the review! Will send a v4 shortly.
Luca
next prev parent reply other threads:[~2019-04-16 16:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 15:06 [PATCH v3 1/3] dt-bindings: input: add GPIO controllable vibrator Luca Weiss
2019-04-12 15:06 ` [PATCH v3 2/3] Input: add a driver for GPIO controllable vibrators Luca Weiss
2019-04-12 17:43 ` Stephen Boyd
2019-04-16 16:02 ` Luca Weiss [this message]
2019-04-12 15:06 ` [PATCH v3 3/3] ARM: dts: msm8974-FP2: Add vibration motor Luca Weiss
2019-04-17 16:02 ` [PATCH v3 1/3] dt-bindings: input: add GPIO controllable vibrator Luca Weiss
2019-04-18 1:35 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1633425.a675zxgQUS@g550jk \
--to=luca@z3ntu.xyz \
--cc=baolin.wang@linaro.org \
--cc=colyli@suse.de \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masneyb@onstation.org \
--cc=mchehab+samsung@kernel.org \
--cc=p.paillet@st.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=xiaotong.lu@spreadtrum.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).