From: Qing Wang <wangqing@vivo.com>
To: "Jiri Kosina" <jikos@kernel.org>,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
"Bruno Prémont" <bonbons@linux-vserver.org>,
"Stefan Achatz" <erazor_de@users.sourceforge.net>,
"Jonathan Cameron" <jic23@kernel.org>,
"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org
Cc: Qing Wang <wangqing@vivo.com>
Subject: [PATCH V2 0/5] hid: replace snprintf in show functions with sysfs_emit
Date: Fri, 15 Oct 2021 04:07:27 -0700 [thread overview]
Message-ID: <1634296054-6971-1-git-send-email-wangqing@vivo.com> (raw)
According to Documentation/filesystems/sysfs.txt:
show() methods of device attributes should return the number
of bytes printed into the buffer. This is the return value of
scnprintf(). snprintf() returns the length the resulting string.
So, show() should not use snprintf() when formatting
the value to be returned to user space.
Also, use sysfs_emit directly makes more sense.
Qing Wang (5):
hid-lenovo: replace snprintf in show functions with sysfs_emit
hid-picolcd: replace snprintf in show functions with sysfs_emit
hid-roccat: replace snprintf in show functions with sysfs_emit
hid-sensor: replace snprintf in show functions with sysfs_emit
hid-sony: replace snprintf in show functions with sysfs_emit
drivers/hid/hid-lenovo.c | 16 ++++++++--------
drivers/hid/hid-picolcd_core.c | 6 +++---
drivers/hid/hid-roccat-isku.c | 2 +-
drivers/hid/hid-roccat-kone.c | 12 ++++++------
drivers/hid/hid-roccat-koneplus.c | 4 ++--
drivers/hid/hid-roccat-kovaplus.c | 10 +++++-----
drivers/hid/hid-roccat-pyra.c | 6 +++---
drivers/hid/hid-sensor-custom.c | 2 +-
drivers/hid/hid-sony.c | 6 +++---
9 files changed, 32 insertions(+), 32 deletions(-)
--
2.7.4
next reply other threads:[~2021-10-15 11:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 11:07 Qing Wang [this message]
2021-10-15 11:07 ` [PATCH V2 1/5] hid-lenovo: replace snprintf in show functions with sysfs_emit Qing Wang
2021-10-15 13:51 ` Jonathan Cameron
2021-10-15 11:07 ` [PATCH V2 2/5] hid-picolcd: " Qing Wang
2021-10-15 11:07 ` [PATCH V2 3/5] hid-roccat: " Qing Wang
2021-10-15 11:07 ` [PATCH V2 4/5] hid-sensor: " Qing Wang
2021-10-15 13:48 ` Jonathan Cameron
2021-10-15 11:07 ` [PATCH V2 5/5] hid-sony: " Qing Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1634296054-6971-1-git-send-email-wangqing@vivo.com \
--to=wangqing@vivo.com \
--cc=benjamin.tissoires@redhat.com \
--cc=bonbons@linux-vserver.org \
--cc=erazor_de@users.sourceforge.net \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).