Hi Prashant, On Mon, 4 Oct 2021 10:07:09 -0700, Prashant Malani wrote: > The Chrome EC's features are returned through an > ec_response_get_features struct, but they are stored in an independent > array. Although the two are effectively the same at present (2 unsigned > 32 bit ints), there is the possibility that they could go out of sync. > Avoid this by only using the EC struct to store the features. Applied, thanks! [1/2] platform/chrome: cros_ec_proto: Use EC struct for features commit: 7ff22787ba49c2e66dcec92f3e2b79ef6b6a0d71 [2/2] platform/chrome: cros_ec_proto: Use ec_command for check_features commit: 297d34e73d491a3edbd6e8c31d33ec90447a908b Best regards, -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org