* [PATCH] nbd: code clean for kiocb_done()
@ 2021-11-04 4:34 Wu Bo
0 siblings, 0 replies; only message in thread
From: Wu Bo @ 2021-11-04 4:34 UTC (permalink / raw)
To: josef, axboe; +Cc: linux-block, nbd, linux-kernel, linfeilong, wubo40
A simple code clean for nbd_genl_status()
Signed-off-by: Wu Bo <wubo40@huawei.com>
---
drivers/block/nbd.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index b47b2a8..175ea97 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -2375,7 +2375,6 @@ static int nbd_genl_status(struct sk_buff *skb, struct genl_info *info)
reply_head = genlmsg_put_reply(reply, info, &nbd_genl_family, 0,
NBD_CMD_STATUS);
if (!reply_head) {
- nlmsg_free(reply);
goto out;
}
@@ -2383,7 +2382,6 @@ static int nbd_genl_status(struct sk_buff *skb, struct genl_info *info)
if (index == -1) {
ret = idr_for_each(&nbd_index_idr, &status_cb, reply);
if (ret) {
- nlmsg_free(reply);
goto out;
}
} else {
@@ -2392,7 +2390,6 @@ static int nbd_genl_status(struct sk_buff *skb, struct genl_info *info)
if (nbd) {
ret = populate_nbd_status(nbd, reply);
if (ret) {
- nlmsg_free(reply);
goto out;
}
}
@@ -2401,6 +2398,8 @@ static int nbd_genl_status(struct sk_buff *skb, struct genl_info *info)
genlmsg_end(reply, reply_head);
ret = genlmsg_reply(reply, info);
out:
+ if (reply)
+ nlmsg_free(reply);
mutex_unlock(&nbd_index_mutex);
return ret;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-11-04 4:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-04 4:34 [PATCH] nbd: code clean for kiocb_done() Wu Bo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).