From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90227C433F5 for ; Wed, 17 Nov 2021 17:02:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E83263212 for ; Wed, 17 Nov 2021 17:02:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238808AbhKQRFn (ORCPT ); Wed, 17 Nov 2021 12:05:43 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:39194 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238480AbhKQRFm (ORCPT ); Wed, 17 Nov 2021 12:05:42 -0500 Received: from pendragon.ideasonboard.com (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3A8DCE7; Wed, 17 Nov 2021 18:02:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1637168561; bh=o22ULqTwaYVqhi4MuajTZOxo0Y+YXB95Tev8CMJcCMk=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=hOJFfAdFL7OEJsEpm9GwJvQ+zqASWx2gHglkOOhnWoph6KoAyxvTjjoWSKI00D1yK 3tnmfT+DRr0DfIO1JBUISqd+srJy0gO2ymZ+WqG5pSkXjgJXyj4txWjRFdSqmvZB0f rZz2f9IJ7p2vifg7apWMAWCCDA2zltyzhq06cij4= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20211117163239.529781-1-kieran.bingham+renesas@ideasonboard.com> Subject: Re: [PATCH] gpu: drm: panel-edp: Fix edp_panel_entry documentation From: Kieran Bingham Cc: dri-devel@lists.freedesktop.org, Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Linus Walleij , open list To: Doug Anderson Date: Wed, 17 Nov 2021 17:02:38 +0000 Message-ID: <163716855845.420308.7037966419706240111@Monstersaurus> User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Doug Anderson (2021-11-17 16:49:43) > Hi, >=20 > On Wed, Nov 17, 2021 at 8:32 AM Kieran Bingham > wrote: > > > > The edp_panel_entry members 'delay' and 'name' are documented, but > > without the correct syntax for kernel doc. > > > > This generates the following warnings: > > > > drivers/gpu/drm/panel/panel-edp.c:204: warning: Function parameter or m= ember 'delay' not described in 'edp_panel_entry' > > drivers/gpu/drm/panel/panel-edp.c:204: warning: Function parameter or m= ember 'name' not described in 'edp_panel_entry' > > > > Fix them accordingly. > > > > Fixes: 5540cf8f3e8d ("drm/panel-edp: Implement generic "edp-panel"s pro= bed by EDID") > > Signed-off-by: Kieran Bingham > > --- > > drivers/gpu/drm/panel/panel-edp.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > Thanks! Pushed to drm-misc-next (though technically it's a fix, it > didn't seem urgent enough to go through -fixes. Hopefully this is OK). >=20 Certainly, I agree it's not urgent. I wasn't even sure if I should add the Fixes tag, but I figured if I left it out someone would jump in with it ;-) > 1e66f04c14ab gpu: drm: panel-edp: Fix edp_panel_entry documentation >=20 > -Doug Thanks Kieran