linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/3] Add QCM2290 RPM power domain support
@ 2021-11-08 13:44 Shawn Guo
  2021-11-08 13:44 ` [PATCH 1/3] soc: qcom: rpmpd: Drop unused res_name from struct rpmpd Shawn Guo
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Shawn Guo @ 2021-11-08 13:44 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Rob Herring, Rajendra Nayak, Loic Poulain, devicetree,
	linux-arm-msm, linux-kernel, Shawn Guo

The first patch is a separate cleanup, and the rest two add RPM power
domain support for QCM2290.

Shawn Guo (3):
  soc: qcom: rpmpd: Drop unused res_name from struct rpmpd
  dt-bindings: power: rpmpd: Add QCM2290 support
  soc: qcom: rpmpd: Add QCM2290 support

 .../devicetree/bindings/power/qcom,rpmpd.yaml |  1 +
 drivers/soc/qcom/rpmpd.c                      | 19 ++++++++++++++++++-
 include/dt-bindings/power/qcom-rpmpd.h        | 10 ++++++++++
 3 files changed, 29 insertions(+), 1 deletion(-)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/3] soc: qcom: rpmpd: Drop unused res_name from struct rpmpd
  2021-11-08 13:44 [PATCH 0/3] Add QCM2290 RPM power domain support Shawn Guo
@ 2021-11-08 13:44 ` Shawn Guo
  2021-11-20 23:55   ` (subset) " Bjorn Andersson
  2021-11-08 13:44 ` [PATCH 2/3] dt-bindings: power: rpmpd: Add QCM2290 support Shawn Guo
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 6+ messages in thread
From: Shawn Guo @ 2021-11-08 13:44 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Rob Herring, Rajendra Nayak, Loic Poulain, devicetree,
	linux-arm-msm, linux-kernel, Shawn Guo

The res_name field in struct rpmpd is unused.  Drop it.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
 drivers/soc/qcom/rpmpd.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/soc/qcom/rpmpd.c b/drivers/soc/qcom/rpmpd.c
index 4f69fb9b2e0e..3e7905854eb9 100644
--- a/drivers/soc/qcom/rpmpd.c
+++ b/drivers/soc/qcom/rpmpd.c
@@ -102,7 +102,6 @@ struct rpmpd {
 	const bool active_only;
 	unsigned int corner;
 	bool enabled;
-	const char *res_name;
 	const int res_type;
 	const int res_id;
 	struct qcom_smd_rpm *rpm;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/3] dt-bindings: power: rpmpd: Add QCM2290 support
  2021-11-08 13:44 [PATCH 0/3] Add QCM2290 RPM power domain support Shawn Guo
  2021-11-08 13:44 ` [PATCH 1/3] soc: qcom: rpmpd: Drop unused res_name from struct rpmpd Shawn Guo
@ 2021-11-08 13:44 ` Shawn Guo
  2021-11-08 13:44 ` [PATCH 3/3] soc: qcom: " Shawn Guo
  2021-11-20 23:55 ` [PATCH 0/3] Add QCM2290 RPM power domain support Bjorn Andersson
  3 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2021-11-08 13:44 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Rob Herring, Rajendra Nayak, Loic Poulain, devicetree,
	linux-arm-msm, linux-kernel, Shawn Guo

Add compatible and constants for the power domains exposed by the
QCM2290 RPM.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
 .../devicetree/bindings/power/qcom,rpmpd.yaml          |  1 +
 include/dt-bindings/power/qcom-rpmpd.h                 | 10 ++++++++++
 2 files changed, 11 insertions(+)

diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
index e810480e3eb7..a6d51d51d2c7 100644
--- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
+++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
@@ -24,6 +24,7 @@ properties:
       - qcom,msm8994-rpmpd
       - qcom,msm8996-rpmpd
       - qcom,msm8998-rpmpd
+      - qcom,qcm2290-rpmpd
       - qcom,qcs404-rpmpd
       - qcom,sdm660-rpmpd
       - qcom,sc7180-rpmhpd
diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
index 960f7976a807..340b0ffe5eb8 100644
--- a/include/dt-bindings/power/qcom-rpmpd.h
+++ b/include/dt-bindings/power/qcom-rpmpd.h
@@ -219,6 +219,16 @@
 #define SM6115_VDD_LPI_CX	6
 #define SM6115_VDD_LPI_MX	7
 
+/* QCM2290 Power Domains */
+#define QCM2290_VDDCX		0
+#define QCM2290_VDDCX_AO	1
+#define QCM2290_VDDCX_VFL	2
+#define QCM2290_VDDMX		3
+#define QCM2290_VDDMX_AO	4
+#define QCM2290_VDDMX_VFL	5
+#define QCM2290_VDD_LPI_CX	6
+#define QCM2290_VDD_LPI_MX	7
+
 /* RPM SMD Power Domain performance levels */
 #define RPM_SMD_LEVEL_RETENTION       16
 #define RPM_SMD_LEVEL_RETENTION_PLUS  32
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 3/3] soc: qcom: rpmpd: Add QCM2290 support
  2021-11-08 13:44 [PATCH 0/3] Add QCM2290 RPM power domain support Shawn Guo
  2021-11-08 13:44 ` [PATCH 1/3] soc: qcom: rpmpd: Drop unused res_name from struct rpmpd Shawn Guo
  2021-11-08 13:44 ` [PATCH 2/3] dt-bindings: power: rpmpd: Add QCM2290 support Shawn Guo
@ 2021-11-08 13:44 ` Shawn Guo
  2021-11-20 23:55 ` [PATCH 0/3] Add QCM2290 RPM power domain support Bjorn Andersson
  3 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2021-11-08 13:44 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Rob Herring, Rajendra Nayak, Loic Poulain, devicetree,
	linux-arm-msm, linux-kernel, Shawn Guo

QCM2290 has the same RPM power domains as SM6115.  Add QCM2290
support by reusing SM6115 power domains.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
 drivers/soc/qcom/rpmpd.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/drivers/soc/qcom/rpmpd.c b/drivers/soc/qcom/rpmpd.c
index 3e7905854eb9..36b2381039e6 100644
--- a/drivers/soc/qcom/rpmpd.c
+++ b/drivers/soc/qcom/rpmpd.c
@@ -395,6 +395,23 @@ static const struct rpmpd_desc sm6115_desc = {
 	.max_state = RPM_SMD_LEVEL_TURBO_NO_CPR,
 };
 
+static struct rpmpd *qcm2290_rpmpds[] = {
+	[QCM2290_VDDCX] = &sm6115_vddcx,
+	[QCM2290_VDDCX_AO] = &sm6115_vddcx_ao,
+	[QCM2290_VDDCX_VFL] = &sm6115_vddcx_vfl,
+	[QCM2290_VDDMX] = &sm6115_vddmx,
+	[QCM2290_VDDMX_AO] = &sm6115_vddmx_ao,
+	[QCM2290_VDDMX_VFL] = &sm6115_vddmx_vfl,
+	[QCM2290_VDD_LPI_CX] = &sm6115_vdd_lpi_cx,
+	[QCM2290_VDD_LPI_MX] = &sm6115_vdd_lpi_mx,
+};
+
+static const struct rpmpd_desc qcm2290_desc = {
+	.rpmpds = qcm2290_rpmpds,
+	.num_pds = ARRAY_SIZE(qcm2290_rpmpds),
+	.max_state = RPM_SMD_LEVEL_TURBO_NO_CPR,
+};
+
 static const struct of_device_id rpmpd_match_table[] = {
 	{ .compatible = "qcom,mdm9607-rpmpd", .data = &mdm9607_desc },
 	{ .compatible = "qcom,msm8916-rpmpd", .data = &msm8916_desc },
@@ -404,6 +421,7 @@ static const struct of_device_id rpmpd_match_table[] = {
 	{ .compatible = "qcom,msm8994-rpmpd", .data = &msm8994_desc },
 	{ .compatible = "qcom,msm8996-rpmpd", .data = &msm8996_desc },
 	{ .compatible = "qcom,msm8998-rpmpd", .data = &msm8998_desc },
+	{ .compatible = "qcom,qcm2290-rpmpd", .data = &qcm2290_desc },
 	{ .compatible = "qcom,qcs404-rpmpd", .data = &qcs404_desc },
 	{ .compatible = "qcom,sdm660-rpmpd", .data = &sdm660_desc },
 	{ .compatible = "qcom,sm6115-rpmpd", .data = &sm6115_desc },
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/3] Add QCM2290 RPM power domain support
  2021-11-08 13:44 [PATCH 0/3] Add QCM2290 RPM power domain support Shawn Guo
                   ` (2 preceding siblings ...)
  2021-11-08 13:44 ` [PATCH 3/3] soc: qcom: " Shawn Guo
@ 2021-11-20 23:55 ` Bjorn Andersson
  3 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2021-11-20 23:55 UTC (permalink / raw)
  To: Shawn Guo
  Cc: linux-arm-msm, Loic Poulain, linux-kernel, devicetree,
	Rob Herring, Rajendra Nayak

On Mon, 8 Nov 2021 21:44:39 +0800, Shawn Guo wrote:
> The first patch is a separate cleanup, and the rest two add RPM power
> domain support for QCM2290.
> 
> Shawn Guo (3):
>   soc: qcom: rpmpd: Drop unused res_name from struct rpmpd
>   dt-bindings: power: rpmpd: Add QCM2290 support
>   soc: qcom: rpmpd: Add QCM2290 support
> 
> [...]

Applied, thanks!

[1/3] soc: qcom: rpmpd: Drop unused res_name from struct rpmpd
      commit: 7ba9dd0d04a8af868bc0785d79bde4ac0240328f
[2/3] dt-bindings: power: rpmpd: Add QCM2290 support
      commit: 2475fcfbe4e383d586c5a58711e436d83a2bdfe6
[3/3] soc: qcom: rpmpd: Add QCM2290 support
      commit: 1cd3921aa95ebf4a6d1f93fb736449441c530aa1

Best regards,
-- 
Bjorn Andersson <bjorn.andersson@linaro.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: (subset) [PATCH 1/3] soc: qcom: rpmpd: Drop unused res_name from struct rpmpd
  2021-11-08 13:44 ` [PATCH 1/3] soc: qcom: rpmpd: Drop unused res_name from struct rpmpd Shawn Guo
@ 2021-11-20 23:55   ` Bjorn Andersson
  0 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2021-11-20 23:55 UTC (permalink / raw)
  To: Shawn Guo
  Cc: linux-arm-msm, Loic Poulain, linux-kernel, devicetree,
	Rob Herring, Rajendra Nayak

On Mon, 8 Nov 2021 21:44:40 +0800, Shawn Guo wrote:
> The res_name field in struct rpmpd is unused.  Drop it.
> 
> 

Applied, thanks!

[1/3] soc: qcom: rpmpd: Drop unused res_name from struct rpmpd
      commit: 7ba9dd0d04a8af868bc0785d79bde4ac0240328f

Best regards,
-- 
Bjorn Andersson <bjorn.andersson@linaro.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-11-20 23:56 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-08 13:44 [PATCH 0/3] Add QCM2290 RPM power domain support Shawn Guo
2021-11-08 13:44 ` [PATCH 1/3] soc: qcom: rpmpd: Drop unused res_name from struct rpmpd Shawn Guo
2021-11-20 23:55   ` (subset) " Bjorn Andersson
2021-11-08 13:44 ` [PATCH 2/3] dt-bindings: power: rpmpd: Add QCM2290 support Shawn Guo
2021-11-08 13:44 ` [PATCH 3/3] soc: qcom: " Shawn Guo
2021-11-20 23:55 ` [PATCH 0/3] Add QCM2290 RPM power domain support Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).