From: Jens Axboe <axboe@kernel.dk>
To: io-uring@vger.kernel.org, asml.silence@gmail.com,
Ye Bin <yebin10@huawei.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] io_uring: Fix undefined-behaviour in io_issue_sqe
Date: Sat, 27 Nov 2021 06:41:48 -0700 [thread overview]
Message-ID: <163802050825.624396.15004136636367239529.b4-ty@kernel.dk> (raw)
In-Reply-To: <20211118015907.844807-1-yebin10@huawei.com>
On Thu, 18 Nov 2021 09:59:07 +0800, Ye Bin wrote:
> We got issue as follows:
> ================================================================================
> UBSAN: Undefined behaviour in ./include/linux/ktime.h:42:14
> signed integer overflow:
> -4966321760114568020 * 1000000000 cannot be represented in type 'long long int'
> CPU: 1 PID: 2186 Comm: syz-executor.2 Not tainted 4.19.90+ #12
> Hardware name: linux,dummy-virt (DT)
> Call trace:
> dump_backtrace+0x0/0x3f0 arch/arm64/kernel/time.c:78
> show_stack+0x28/0x38 arch/arm64/kernel/traps.c:158
> __dump_stack lib/dump_stack.c:77 [inline]
> dump_stack+0x170/0x1dc lib/dump_stack.c:118
> ubsan_epilogue+0x18/0xb4 lib/ubsan.c:161
> handle_overflow+0x188/0x1dc lib/ubsan.c:192
> __ubsan_handle_mul_overflow+0x34/0x44 lib/ubsan.c:213
> ktime_set include/linux/ktime.h:42 [inline]
> timespec64_to_ktime include/linux/ktime.h:78 [inline]
> io_timeout fs/io_uring.c:5153 [inline]
> io_issue_sqe+0x42c8/0x4550 fs/io_uring.c:5599
> __io_queue_sqe+0x1b0/0xbc0 fs/io_uring.c:5988
> io_queue_sqe+0x1ac/0x248 fs/io_uring.c:6067
> io_submit_sqe fs/io_uring.c:6137 [inline]
> io_submit_sqes+0xed8/0x1c88 fs/io_uring.c:6331
> __do_sys_io_uring_enter fs/io_uring.c:8170 [inline]
> __se_sys_io_uring_enter fs/io_uring.c:8129 [inline]
> __arm64_sys_io_uring_enter+0x490/0x980 fs/io_uring.c:8129
> invoke_syscall arch/arm64/kernel/syscall.c:53 [inline]
> el0_svc_common+0x374/0x570 arch/arm64/kernel/syscall.c:121
> el0_svc_handler+0x190/0x260 arch/arm64/kernel/syscall.c:190
> el0_svc+0x10/0x218 arch/arm64/kernel/entry.S:1017
> ================================================================================
>
> [...]
Applied, thanks!
[1/1] io_uring: Fix undefined-behaviour in io_issue_sqe
commit: f6223ff799666235a80d05f8137b73e5580077b9
Best regards,
--
Jens Axboe
next prev parent reply other threads:[~2021-11-27 13:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 1:59 [PATCH -next] io_uring: Fix undefined-behaviour in io_issue_sqe Ye Bin
2021-11-27 6:13 ` yebin
2021-11-27 13:41 ` Jens Axboe [this message]
2021-11-27 13:45 ` Jens Axboe
2021-11-29 3:36 ` yebin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163802050825.624396.15004136636367239529.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yebin10@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).