* [PATCH v2] bus: mhi: core: Fix reading wake_capable channel configuration
@ 2021-12-01 1:01 Bhaumik Bhatt
2021-12-03 8:43 ` Manivannan Sadhasivam
0 siblings, 1 reply; 2+ messages in thread
From: Bhaumik Bhatt @ 2021-12-01 1:01 UTC (permalink / raw)
To: manivannan.sadhasivam
Cc: linux-arm-msm, quic_hemantk, quic_jhugo, linux-kernel, mhi,
stable, quic_olgak, loic.poulain, Bhaumik Bhatt
The 'wake-capable' entry in channel configuration is not set when
parsing the configuration specified by the controller driver. Add
the missing entry to ensure channel is correctly specified as a
'wake-capable' channel.
Cc: stable@vger.kernel.org
Fixes: 0cbf260820fa ("bus: mhi: core: Add support for registering MHI controllers")
Signed-off-by: Bhaumik Bhatt <quic_bbhatt@quicinc.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
---
drivers/bus/mhi/core/init.c | 1 +
1 file changed, 1 insertion(+)
v2:
-Update subject as per comments
-Add fixes tag and CC stable
diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
index 5aaca6d..f1ec3441 100644
--- a/drivers/bus/mhi/core/init.c
+++ b/drivers/bus/mhi/core/init.c
@@ -788,6 +788,7 @@ static int parse_ch_cfg(struct mhi_controller *mhi_cntrl,
mhi_chan->offload_ch = ch_cfg->offload_channel;
mhi_chan->db_cfg.reset_req = ch_cfg->doorbell_mode_switch;
mhi_chan->pre_alloc = ch_cfg->auto_queue;
+ mhi_chan->wake_capable = ch_cfg->wake_capable;
/*
* If MHI host allocates buffers, then the channel direction
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] bus: mhi: core: Fix reading wake_capable channel configuration
2021-12-01 1:01 [PATCH v2] bus: mhi: core: Fix reading wake_capable channel configuration Bhaumik Bhatt
@ 2021-12-03 8:43 ` Manivannan Sadhasivam
0 siblings, 0 replies; 2+ messages in thread
From: Manivannan Sadhasivam @ 2021-12-03 8:43 UTC (permalink / raw)
To: Bhaumik Bhatt
Cc: linux-arm-msm, quic_hemantk, quic_jhugo, linux-kernel, mhi,
stable, quic_olgak, loic.poulain
On Tue, Nov 30, 2021 at 05:01:31PM -0800, Bhaumik Bhatt wrote:
> The 'wake-capable' entry in channel configuration is not set when
> parsing the configuration specified by the controller driver. Add
> the missing entry to ensure channel is correctly specified as a
> 'wake-capable' channel.
>
> Cc: stable@vger.kernel.org
> Fixes: 0cbf260820fa ("bus: mhi: core: Add support for registering MHI controllers")
> Signed-off-by: Bhaumik Bhatt <quic_bbhatt@quicinc.com>
> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Applied to mhi-next!
Thanks,
Mani
> ---
> drivers/bus/mhi/core/init.c | 1 +
> 1 file changed, 1 insertion(+)
>
> v2:
> -Update subject as per comments
> -Add fixes tag and CC stable
>
> diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
> index 5aaca6d..f1ec3441 100644
> --- a/drivers/bus/mhi/core/init.c
> +++ b/drivers/bus/mhi/core/init.c
> @@ -788,6 +788,7 @@ static int parse_ch_cfg(struct mhi_controller *mhi_cntrl,
> mhi_chan->offload_ch = ch_cfg->offload_channel;
> mhi_chan->db_cfg.reset_req = ch_cfg->doorbell_mode_switch;
> mhi_chan->pre_alloc = ch_cfg->auto_queue;
> + mhi_chan->wake_capable = ch_cfg->wake_capable;
>
> /*
> * If MHI host allocates buffers, then the channel direction
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-03 8:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-01 1:01 [PATCH v2] bus: mhi: core: Fix reading wake_capable channel configuration Bhaumik Bhatt
2021-12-03 8:43 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).