linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicholas Piggin <npiggin@gmail.com>
To: alex@ghiti.fr, Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 rebased 3/9] powerpc/mm: Remove CONFIG_PPC_MM_SLICES
Date: Wed, 01 Dec 2021 15:50:24 +1000	[thread overview]
Message-ID: <1638337392.ccyk5edcqo.astroid@bobo.none> (raw)
In-Reply-To: <103550e29fc95a6f93ec8848f9ebf9054ca024a3.1637862579.git.christophe.leroy@csgroup.eu>

Excerpts from Christophe Leroy's message of November 26, 2021 3:52 am:
> CONFIG_PPC_MM_SLICES is always selected by hash book3s/64.
> CONFIG_PPC_MM_SLICES is never selected by other platforms.
> 
> Remove it.

I guess there is some remnants of code/data to build 64s hash without 
slices. Maybe without any huge page support? I guess it's probably
broken if it never =n, and not worth maintaining anyway?

Reviewed-by: Nicholas Piggin <npiggin@gmail.com>

> 
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> ---
>  arch/powerpc/include/asm/book3s/64/hash.h |  4 ++--
>  arch/powerpc/include/asm/hugetlb.h        |  2 +-
>  arch/powerpc/include/asm/paca.h           |  7 -------
>  arch/powerpc/include/asm/slice.h          | 13 ++-----------
>  arch/powerpc/kernel/paca.c                |  5 -----
>  arch/powerpc/mm/book3s64/Makefile         |  3 +--
>  arch/powerpc/mm/book3s64/hash_utils.c     | 14 --------------
>  arch/powerpc/platforms/Kconfig.cputype    |  4 ----
>  8 files changed, 6 insertions(+), 46 deletions(-)

  reply	other threads:[~2021-12-01  5:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-25 17:52 [PATCH v2 rebased 0/9] Convert powerpc to default topdown mmap layout Christophe Leroy
2021-11-25 17:52 ` [PATCH v2 rebased 1/9] powerpc/mm: Make slice specific to book3s/64 Christophe Leroy
2021-12-01  5:32   ` Nicholas Piggin
2021-11-25 17:52 ` [PATCH v2 rebased 2/9] powerpc/mm: Move vma_mmu_pagesize() and hugetlb_get_unmapped_area() to slice.c Christophe Leroy
2021-12-01  5:43   ` Nicholas Piggin
2021-11-25 17:52 ` [PATCH v2 rebased 3/9] powerpc/mm: Remove CONFIG_PPC_MM_SLICES Christophe Leroy
2021-12-01  5:50   ` Nicholas Piggin [this message]
2021-11-25 17:52 ` [PATCH v2 rebased 4/9] powerpc/mm: Remove asm/slice.h Christophe Leroy
2021-12-01  5:51   ` Nicholas Piggin
2021-11-25 17:52 ` [PATCH v2 rebased 5/9] powerpc/mm: Call radix__arch_get_unmapped_area() from arch_get_unmapped_area() Christophe Leroy
2021-12-01  6:00   ` Nicholas Piggin
2021-11-25 17:52 ` [PATCH v2 rebased 6/9] mm: Allow arch specific arch_randomize_brk() with CONFIG_ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT Christophe Leroy
2021-11-25 17:52 ` [PATCH v2 rebased 7/9] powerpc/mm: Convert to default topdown mmap layout Christophe Leroy
2021-12-01  6:06   ` Nicholas Piggin
2021-11-25 17:52 ` [PATCH v2 rebased 8/9] powerpc/mm: Properly randomise mmap with slices Christophe Leroy
2021-11-25 17:52 ` [PATCH v2 rebased 9/9] powerpc: Simplify and move arch_randomize_brk() Christophe Leroy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1638337392.ccyk5edcqo.astroid@bobo.none \
    --to=npiggin@gmail.com \
    --cc=alex@ghiti.fr \
    --cc=benh@kernel.crashing.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).