From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
laurent.pinchart@ideasonboard.com, mchehab@kernel.org,
sakari.ailus@linux.intel.com
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH] media: mc: mc-entity.c: Use bitmap_zalloc() when applicable
Date: Thu, 02 Dec 2021 12:38:05 +0000 [thread overview]
Message-ID: <163844868581.3059017.16653620248778368715@Monstersaurus> (raw)
In-Reply-To: <b11f646dda189f490c06bf671f64a2cc0af4d45c.1638397089.git.christophe.jaillet@wanadoo.fr>
Quoting Christophe JAILLET (2021-12-01 22:19:40)
> 'ent_enum->bmap' is a bitmap. So use 'bitmap_zalloc()' to simplify
> code, improve the semantic and avoid some open-coded arithmetic in
> allocator arguments.
>
> Also change the corresponding 'kfree()' into 'bitmap_free()' to keep
> consistency.
>
> While at it, remove a useless 'bitmap_zero()'.
Ah, yes kcalloc zeros memory, so it is doing a redundant clear as well.
Changing to bitmap_zalloc looks a lot better though.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/media/mc/mc-entity.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c
> index c02340698ad6..b411f9796191 100644
> --- a/drivers/media/mc/mc-entity.c
> +++ b/drivers/media/mc/mc-entity.c
> @@ -48,12 +48,10 @@ __must_check int __media_entity_enum_init(struct media_entity_enum *ent_enum,
> int idx_max)
> {
> idx_max = ALIGN(idx_max, BITS_PER_LONG);
> - ent_enum->bmap = kcalloc(idx_max / BITS_PER_LONG, sizeof(long),
> - GFP_KERNEL);
> + ent_enum->bmap = bitmap_zalloc(idx_max, GFP_KERNEL);
> if (!ent_enum->bmap)
> return -ENOMEM;
>
> - bitmap_zero(ent_enum->bmap, idx_max);
> ent_enum->idx_max = idx_max;
>
> return 0;
> @@ -62,7 +60,7 @@ EXPORT_SYMBOL_GPL(__media_entity_enum_init);
>
> void media_entity_enum_cleanup(struct media_entity_enum *ent_enum)
> {
> - kfree(ent_enum->bmap);
> + bitmap_free(ent_enum->bmap);
> }
> EXPORT_SYMBOL_GPL(media_entity_enum_cleanup);
>
> --
> 2.30.2
>
next prev parent reply other threads:[~2021-12-02 12:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 22:19 [PATCH] media: mc: mc-entity.c: Use bitmap_zalloc() when applicable Christophe JAILLET
2021-12-02 12:38 ` Kieran Bingham [this message]
2021-12-03 2:51 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163844868581.3059017.16653620248778368715@Monstersaurus \
--to=kieran.bingham@ideasonboard.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).