From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
bhelgaas@google.com
Cc: "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
robh@kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
"Krzysztof Wilczyński" <kw@linux.com>,
linux-pci@vger.kernel.org, svarbanov@mm-sol.com,
"kernel test robot" <lkp@intel.com>,
bjorn.andersson@linaro.org
Subject: Re: [PATCH v3] PCI: qcom: Use __be16 type to store return value from cpu_to_be16()
Date: Mon, 6 Dec 2021 10:31:02 +0000 [thread overview]
Message-ID: <163878663178.16251.482948854423649218.b4-ty@arm.com> (raw)
In-Reply-To: <20211130080924.266116-1-manivannan.sadhasivam@linaro.org>
On Tue, 30 Nov 2021 13:39:24 +0530, Manivannan Sadhasivam wrote:
> cpu_to_be16() returns __be16 value but the driver uses u16 and that's
> incorrect. Fix it by using __be16 as the data type of bdf_be variable.
>
> The issue was spotted by the below sparse warning:
>
> sparse warnings: (new ones prefixed by >>)
> >> drivers/pci/controller/dwc/pcie-qcom.c:1305:30: sparse: sparse: incorrect type in initializer (different base types) @@ expected unsigned short [usertype] bdf_be @@ got restricted __be16 [usertype] @@
> drivers/pci/controller/dwc/pcie-qcom.c:1305:30: sparse: expected unsigned short [usertype] bdf_be
> drivers/pci/controller/dwc/pcie-qcom.c:1305:30: sparse: got restricted __be16 [usertype]
>
> [...]
Applied to pci/qcom, thanks!
[1/1] PCI: qcom: Use __be16 type to store return value from cpu_to_be16()
https://git.kernel.org/lpieralisi/pci/c/3f13d611aa
Thanks,
Lorenzo
prev parent reply other threads:[~2021-12-06 10:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 8:09 [PATCH v3] PCI: qcom: Use __be16 type to store return value from cpu_to_be16() Manivannan Sadhasivam
2021-12-06 10:31 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163878663178.16251.482948854423649218.b4-ty@arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lkp@intel.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=svarbanov@mm-sol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).