From: "irqchip-bot for Ye Guojin" <tip-bot2@linutronix.de>
To: linux-kernel@vger.kernel.org
Cc: Zeal Robot <zealci@zte.com.cn>, Ye Guojin <ye.guojin@zte.com.cn>,
Florian Fainelli <f.fainelli@gmail.com>,
Marc Zyngier <maz@kernel.org>,
tglx@linutronix.de
Subject: [irqchip: irq/irqchip-fixes] irqchip/irq-bcm7120-l2: Add put_device() after of_find_device_by_node()
Date: Fri, 10 Dec 2021 13:26:22 -0000 [thread overview]
Message-ID: <163914278213.23020.634415261822719928.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20211109055958.130287-1-ye.guojin@zte.com.cn>
The following commit has been merged into the irq/irqchip-fixes branch of irqchip:
Commit-ID: c3fbab7767c53397d7b849799474f5a27cf306e6
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/c3fbab7767c53397d7b849799474f5a27cf306e6
Author: Ye Guojin <ye.guojin@zte.com.cn>
AuthorDate: Tue, 09 Nov 2021 05:59:58
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Fri, 10 Dec 2021 13:23:13
irqchip/irq-bcm7120-l2: Add put_device() after of_find_device_by_node()
This was found by coccicheck:
./drivers/irqchip/irq-bcm7120-l2.c,328,1-7,ERROR missing put_device;
call of_find_device_by_node on line 234, but without a corresponding
object release within this function.
./drivers/irqchip/irq-bcm7120-l2.c,341,1-7,ERROR missing put_device;
call of_find_device_by_node on line 234, but without a corresponding
object release within this function.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Ye Guojin <ye.guojin@zte.com.cn>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20211109055958.130287-1-ye.guojin@zte.com.cn
---
drivers/irqchip/irq-bcm7120-l2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/irq-bcm7120-l2.c b/drivers/irqchip/irq-bcm7120-l2.c
index d80e67a..bb6609c 100644
--- a/drivers/irqchip/irq-bcm7120-l2.c
+++ b/drivers/irqchip/irq-bcm7120-l2.c
@@ -238,6 +238,7 @@ static int __init bcm7120_l2_intc_probe(struct device_node *dn,
}
data->num_parent_irqs = platform_irq_count(pdev);
+ put_device(&pdev->dev);
if (data->num_parent_irqs <= 0) {
pr_err("invalid number of parent interrupts\n");
ret = -ENOMEM;
prev parent reply other threads:[~2021-12-10 13:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 3:29 [PATCH] irqchip/irq-bcm7120-l2: add put_device() after of_find_device_by_node() cgel.zte
2021-11-09 3:40 ` Florian Fainelli
2021-11-09 5:59 ` [PATCH v2] " cgel.zte
2021-11-09 22:37 ` Florian Fainelli
2021-12-10 12:28 ` [irqchip: irq/irqchip-fixes] " irqchip-bot for Ye Guojin
2021-12-10 13:26 ` irqchip-bot for Ye Guojin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163914278213.23020.634415261822719928.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
--cc=ye.guojin@zte.com.cn \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).