From: Richard Weinberger <richard@nod.at>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-mtd <linux-mtd@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>,
Kristof Havasi <havasiefr@gmail.com>
Subject: Re: [PATCH] ubifs: journal: Make sure to not dirty twice for auth nodes
Date: Tue, 29 Sep 2020 10:44:33 +0200 (CEST) [thread overview]
Message-ID: <1641873979.143790.1601369073151.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <20200929083232.GA11648@pengutronix.de>
----- Ursprüngliche Mail -----
> Von: "Sascha Hauer" <s.hauer@pengutronix.de>
> An: "richard" <richard@nod.at>
> CC: "linux-mtd" <linux-mtd@lists.infradead.org>, "linux-kernel" <linux-kernel@vger.kernel.org>, "stable"
> <stable@vger.kernel.org>, "Kristof Havasi" <havasiefr@gmail.com>
> Gesendet: Dienstag, 29. September 2020 10:32:32
> Betreff: Re: [PATCH] ubifs: journal: Make sure to not dirty twice for auth nodes
> On Mon, Sep 28, 2020 at 09:06:12PM +0200, Richard Weinberger wrote:
>> When removing the last reference of an inode the size of an auth node
>> is already part of write_len. So we must not call ubifs_add_auth_dirt().
>> Call it only when needed.
>>
>> Cc: <stable@vger.kernel.org>
>> Cc: Sascha Hauer <s.hauer@pengutronix.de>
>> Cc: Kristof Havasi <havasiefr@gmail.com>
>> Fixes: 6a98bc4614de ("ubifs: Add authentication nodes to journal")
>> Reported-by: Kristof Havasi <havasiefr@gmail.com>
>> Signed-off-by: Richard Weinberger <richard@nod.at>
>
> Looked at the code until I understood what the problem is and how it is
> fixed, so:
>
> Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
Applied to fixes branch!
Thanks,
//richard
prev parent reply other threads:[~2020-09-29 8:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 19:06 [PATCH] ubifs: journal: Make sure to not dirty twice for auth nodes Richard Weinberger
2020-09-29 8:32 ` Sascha Hauer
2020-09-29 8:44 ` Richard Weinberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1641873979.143790.1601369073151.JavaMail.zimbra@nod.at \
--to=richard@nod.at \
--cc=havasiefr@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).