From: "irqchip-bot for Sander Vanheule" <tip-bot2@linutronix.de>
To: linux-kernel@vger.kernel.org
Cc: Sander Vanheule <sander@svanheule.net>,
Marc Zyngier <maz@kernel.org>,
tglx@linutronix.de
Subject: [irqchip: irq/irqchip-fixes] irqchip/realtek-rtl: Map control data to virq
Date: Mon, 17 Jan 2022 12:24:21 -0000 [thread overview]
Message-ID: <164242226169.16921.10741933704404329926.tip-bot2@tip-bot2> (raw)
In-Reply-To: =?utf-8?q?=3C4b4936606480265db47df152f00bc2ed46340599=2E16417?= =?utf-8?q?39718=2Egit=2Esander=40svanheule=2Enet=3E?=
The following commit has been merged into the irq/irqchip-fixes branch of irqchip:
Commit-ID: 291e79c7e2eb6fdc016453597b78482e06199d0f
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/291e79c7e2eb6fdc016453597b78482e06199d0f
Author: Sander Vanheule <sander@svanheule.net>
AuthorDate: Sun, 09 Jan 2022 15:54:32 +01:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Mon, 17 Jan 2022 12:13:58
irqchip/realtek-rtl: Map control data to virq
The driver assigned the irqchip and irq handler to the hardware irq,
instead of the virq. This is incorrect, and only worked because these
irq numbers happened to be the same on the devices used for testing the
original driver.
Fixes: 9f3a0f34b84a ("irqchip: Add support for Realtek RTL838x/RTL839x interrupt controller")
Signed-off-by: Sander Vanheule <sander@svanheule.net>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/4b4936606480265db47df152f00bc2ed46340599.1641739718.git.sander@svanheule.net
---
drivers/irqchip/irq-realtek-rtl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-realtek-rtl.c b/drivers/irqchip/irq-realtek-rtl.c
index fd9f275..d6788dd 100644
--- a/drivers/irqchip/irq-realtek-rtl.c
+++ b/drivers/irqchip/irq-realtek-rtl.c
@@ -62,7 +62,7 @@ static struct irq_chip realtek_ictl_irq = {
static int intc_map(struct irq_domain *d, unsigned int irq, irq_hw_number_t hw)
{
- irq_set_chip_and_handler(hw, &realtek_ictl_irq, handle_level_irq);
+ irq_set_chip_and_handler(irq, &realtek_ictl_irq, handle_level_irq);
return 0;
}
reply other threads:[~2022-01-17 12:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164242226169.16921.10741933704404329926.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=sander@svanheule.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).