From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752285AbcGUKzK (ORCPT ); Thu, 21 Jul 2016 06:55:10 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:50163 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752195AbcGUKzG convert rfc822-to-8bit (ORCPT ); Thu, 21 Jul 2016 06:55:06 -0400 From: Arnd Bergmann To: Wan Zongshun Cc: linux-arm-kernel@lists.infradead.org, Russell King , devicetree@vger.kernel.org, linux-clk@vger.kernel.org, jason@lakedaemon.net, Daniel Lezcano , linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, Thomas Gleixner , Wan Zongshun Subject: Re: [PATCH v2 09/10] Documentation: devicetree: Add dts description for nuc900 Date: Mon, 11 Jul 2016 09:46:50 +0200 Message-ID: <1644086.jqpXDrkuq8@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <578300E2.5000405@iommu.org> References: <1468136542-2656-1-git-send-email-vw@iommu.org> <1850749.ap1S8Xq0fA@wuerfel> <578300E2.5000405@iommu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K0:tyj32/2B+Ek2a1JdfX4iM23ZrjFX+pPj5+DcKenRsiMrCkCZ2Zh exItH9S/2qJ/Umby1bj4FxJ3PyYKXPQXujLsLlTvjDyykSC3IUz7rRSqY9LyC1dGAgEGUez UXDou2XQUM7ULZ8zlHzPk2aTHOy8Kxxo2dSJpJajJZSPcSzuMoUPxofsh583sbse2xaTLiH LvMIMm/58IclFk0PTScJw== X-UI-Out-Filterresults: notjunk:1;V01:K0:WkMHSr5ASK0=:ZlhWwMjem9gmeawThIyRH+ vgyY6hQcqPdOjWQ0SxI7caH24/rvYAIDgRrHbXxB+Heox0E+GgtPt0Ua4mjIMjdoZ1oTR3fy6 jqkLBLcRG7dpYrUywZdzq1cbPMJwSQspEkycmWBo/4FqtH+ICJgkouP5ivW8qj4lJHYYpVWZF 1Abry8R4UUIqmkPJwwQ2ubOGBkncqqbbdcwLaQ+zZesQEK0gXxLam7YbKNtUq5xU19wjTAwXj XmsSoHUj8PkLnAQLgJ5iOBOFMaxmeP/ZU/odKk0B5d7yiTQp9M56i5YfoUL89OeFySDZkV2N+ OKa02XAdbYSbvgg8WxIchKCx3KvIt7+WTlU6DfXL0Vg0hp1HFYwyvQ6MoI0SW/phruQTJLq1X kJ10BrIoxaTYksIzhMhXNUeWlkOFyUmjjuB73IaK2ia4r08adQ7vXG+xFgzVE2Sb4TX2mnZUg 70cGfZa0U9S7OLb192NLvvNXYCK11RIn7xTlLVWIjkDZ5l0mLYGp2HC69lckY+RsrdhY0AOhh 2wJF25wRaBVOjFLhNY+VsTJl5+lsOtxz12gq69wc+J8zU7ITqS41SONrzkS/ZNpBSV+FEzqic FLXCcp/Ak2Yxss4a5rwIHfyjz0swFMb3ufk4oqmzqMTAzCrampHKdN1U/vrDr7Kml3WOwxjyz ODjkq3/vwVHsh7Eyf9zLEo5fDJ6Zsa5g3Cn8vaHA2Y23Y6ntp8Ii0v4x6X5oXNAY+cZRuqI9O USF1hTQit4zJWbry Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, July 11, 2016 10:13:54 AM CEST Wan Zongshun wrote: > > On 2016年07月11日 06:17, Arnd Bergmann wrote: > > On Sunday, July 10, 2016 3:42:21 PM CEST Wan Zongshun wrote: > >> + > >> +Required properties: > >> +- compatible : Should be "nuvoton,nuc970-tmr" > >> +- reg : Address and length of the register set > >> +- clocks : Reference on the timer input clock > >> +- interrupts : Reference to the timer interrupt > >> + > >> +Example: > >> + > >> +tmr@0xb8001000 { > > > > The name should be "timer", not "tmr", and the address should > > not contain a leading "0x". > > Ok, so all dts addresses has no need contain a leading "0x"? In properties, you need the leading 0x for hexadecimal numbers, in the node name the portion after the "@" depends on the bus, but is usually just the value of the address in hexadecimal without the leading 0x. > > > >> + compatible = "nuvoton,nuc970-tmr"; > >> + reg = <0xb8001000 0x1000>; > >> + interrupts = <16>; > >> + clocks = <&clks TIMER0_GATE>, > >> + <&clks TIMER1_GATE>; > >> + clock-names = "timer0", "timer1"; > >> +}; > > > > The clocks/clock-names description does not match the example: > > you only define a single clock in the required properties, but > > have two separate inputs in the example. Please fix one or the > > other. > > Two clocks are necessary, so I only need modify this description like? > > Required properties: > clocks : Reference on the timer input clock, This list should be 2 > clocks, the order is timer0 , timer1. > > Is it ok? Yes, looks good. Arnd