From: "NeilBrown" <neilb@suse.de>
To: "Ian Kent" <raven@themaw.net>
Cc: autofs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [ANNOUNCE] autofs 5.1.8 release
Date: Thu, 10 Feb 2022 08:59:48 +1100 [thread overview]
Message-ID: <164444398868.27779.4643380819577932837@noble.neil.brown.name> (raw)
In-Reply-To: <b54fb31652a4ba76b39db66b8ae795ee3af6f025.camel@themaw.net>
On Tue, 19 Oct 2021, Ian Kent wrote:
> Hi all,
>
> It's time for a release, autofs-5.1.8.
>
...
> - also require TCP_REQUESTED when setting NFS port.
Unfortunately that last patch is buggy. TCP_REQUESTED is masked out in
the caller.
Maybe the following is best.
NeilBrown
From: NeilBrown <neilb@suse.de>
Subject: [PATCH] Test TCP request correctly in nfs_get_info()
The TCP_REQUESTED flag is masked out by the caller, so it never gets to
nfs_get_info().
We can test if TCP was requested by examining the 'proto' parameter.
Signed-off-by: NeilBrown <neilb@suse.de>
diff --git a/modules/replicated.c b/modules/replicated.c
index 09075dd0c1b4..3ac7ee432e73 100644
--- a/modules/replicated.c
+++ b/modules/replicated.c
@@ -291,7 +291,7 @@ static unsigned int get_nfs_info(unsigned logopt, struct host *host,
rpc_info->proto = proto;
if (port < 0) {
- if ((version & NFS4_REQUESTED) && (version & TCP_REQUESTED))
+ if ((version & NFS4_REQUESTED) && (proto == IPPROTO_TCP))
rpc_info->port = NFS_PORT;
else
port = 0;
next prev parent reply other threads:[~2022-02-09 22:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 6:07 [ANNOUNCE] autofs 5.1.8 release Ian Kent
2022-02-09 21:59 ` NeilBrown [this message]
2022-02-14 5:34 ` Ian Kent
2022-02-14 22:46 ` NeilBrown
2022-02-15 7:00 ` Ian Kent
2022-02-15 7:56 ` Stanislav Levin
2022-02-17 2:57 ` NeilBrown
2022-02-18 4:47 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164444398868.27779.4643380819577932837@noble.neil.brown.name \
--to=neilb@suse.de \
--cc=autofs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).